sycamore-rs / sycamore

A library for creating reactive web apps in Rust and WebAssembly
https://sycamore-rs.netlify.app
MIT License
2.79k stars 148 forks source link

Add underline and bold for navigation improvements #660

Closed Hmikihiro closed 7 months ago

Hmikihiro commented 7 months ago

619

I implemented only "(A) highlight current page in navbar" image

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 60.44%. Comparing base (a7bec19) to head (aab0bcf). Report is 1 commits behind head on master.

Files Patch % Lines
website/src/main.rs 0.00% 11 Missing :warning:
website/src/header.rs 0.00% 6 Missing :warning:
website/src/sidebar.rs 0.00% 5 Missing :warning:
website/src/content.rs 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #660 +/- ## ========================================== - Coverage 61.06% 60.44% -0.63% ========================================== Files 54 54 Lines 8985 8540 -445 ========================================== - Hits 5487 5162 -325 + Misses 3498 3378 -120 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hmikihiro commented 7 months ago

Thank you check and fix my code. I will be careful in view! macro from next time.