search

sycamore-rs / sycamore

A library for creating reactive web apps in Rust and WebAssembly
https://sycamore-rs.netlify.app
MIT License
2.79k stars 148 forks source link

Update trunk to v0.19.1 and disable minification for hydrate example #665

Closed lukechu10 closed 6 months ago

lukechu10 commented 6 months ago

Fixes #662

This PR updates Trunk to v0.19.1 which supports minification of assets. This however breaks the hydrate example which relies on hydration markers in the produced HTML file that are removed by minification. To fix this, we disable minification in examples/hydrate/Trunk.toml.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.45%. Comparing base (11c9fb0) to head (17bc27c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #665 +/- ## ======================================= Coverage 60.45% 60.45% ======================================= Files 54 54 Lines 8539 8539 ======================================= Hits 5162 5162 Misses 3377 3377 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.