search

syd711 / vpin-studio

Competition, table, and player management for VPins.
MIT License
32 stars 2 forks source link

Check delete operation for duplicated table #121

Closed syd711 closed 9 months ago

syd711 commented 9 months ago

Seems the server does not resolve the filename then properly during renaming or deletions.

This was my first time using VPin Studio to remove games and I had a bit of a strange thing happen. I had two different games (Funhouse and Who Dunnit), I had two different versions of each installed. I wanted to remove one version of each. I selected the version of Funhouse I wanted to remove, right clicked and selected delete. I then selected, Remove from Pinup Popper, Delete Game Files and Delete Directb2s file. Everything worked as I expected. The vpx, backglass and media files were all removed and the other Funhouse game was not affected, all it's files were still there and everything worked.

I believe I did the exact same process with Who Dunnit but all the media files for both versions were deleted. The vpx and backglass file for the one I wanted to keep was still there.

Not sure if I did something incorrectly or if it might have been something in the file naming. I have a backup and looking at the file names nothing jumps out but I will attach images and maybe someone will notice something.

The only other difference I can think of was that I had an alias setup for Funhouse but not for Who Dunnit.

I also noticed none of the thumb files were not removed. image image

syd711 commented 9 months ago

The issue is caused by an "unsharp" lookup of media assets using the "Game Name" value. The existing lookup may pick up assets that are from a different game, starting with the same game name e.g. "funhouse" and "funhouse mod". Deleting or renaming the "Game Name" field will affect assets of table with game name "funhouse mod" too.

syd711 commented 9 months ago

Issue has been fixed and will be part of the next version (> 2.11.1)