syd711 / vpin-studio

Competition, table, and player management for VPins.
MIT License
28 stars 2 forks source link

Method to upload Ultra DMD #123

Closed curtiskam closed 7 months ago

curtiskam commented 7 months ago

No existing problem

I'd like there to be a way to upload Ultra DMDs for tables that use them.

I'm currently remoting into my pinball PC and using file transfer to upload the Ultra DMDs

syd711 commented 7 months ago

I have to confess, I haven't used it yet, but the DMD section contains an upload button. There you can upload zip files which contain Ultra and Flex DMDs. Did you try that?

For the next version, I have also moved all upload actions into one menu so that it is more obvious what upload types are available.

curtiskam commented 7 months ago

I tried with the last FlexDMD table that I downloaded (Futurama), and it told me the file was invalid. There was an UltraDMD before that that I couldn’t figure out how to upload, but I don’t remember which one.

I’ll try with the next one that pops up and let you know.

From: syd711 @.> Sent: Tuesday, January 30, 2024 2:31 AM To: syd711/vpin-studio @.> Cc: Curtis Kaminski @.>; Author @.> Subject: Re: [syd711/vpin-studio] Method to upload Ultra DMD (Issue #123)

I have to confess, I haven't used it yet, but the DMD section contains an upload button. There you can upload zip files which contain Ultra and Flex DMDs. Did you try that?

For the next version, I have also moved all upload actions into one menu so that it is more obvious what upload types are available.

— Reply to this email directly, view it on GitHub https://github.com/syd711/vpin-studio/issues/123#issuecomment-1916231455 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADCH3LBVCNT472VAYHFAXQLYRCOUJAVCNFSM6AAAAABCQBARF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJWGIZTCNBVGU . You are receiving this because you authored the thread. https://github.com/notifications/beacon/ADCH3LCFWSV4TGFM5NPPUVDYRCOUJA5CNFSM6AAAAABCQBARF6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTSG5PR6.gif Message ID: @. @.> >

syd711 commented 7 months ago

Ah, I see. I'll review this upload and also test it with the Futurama table.

syd711 commented 7 months ago

Thank. The problem was that the upload validator check was case sensitive. E.g. for Futurama the folder is called "flexDMD" instead for "FlexDMD". The issue has been fixed and comes with the next version (> 2.11.1).

syd711 commented 7 months ago

Re-opened as reminder for myself: there are other tables not using the this lower case syntax, e.g. cyberraceDMD. The check need to be modified so that only the "DMD" suffix is checked.

syd711 commented 7 months ago

Softened check, so that all "dmd" suffixes are accepted.

syd711 commented 7 months ago

Sorry, still broken.

syd711 commented 7 months ago

That could have went smoother. Anyway: The last hotfix did lowercase the target folder and ignored subfolders. Both issues have been fixed. Tested with cyberrace, futurama and blood machines. The fix comes with version > 2.11.2