syd711 / vpin-studio

Competition, table, and player management for VPins.
MIT License
28 stars 2 forks source link

Remote Client : Extremely High CPU and Memory usage when idle or minimized #126

Closed Ltek closed 7 months ago

Ltek commented 7 months ago

Describe the bug I'm running the client remotely When loaded VPS runs on average 25% of the CPU, even when idle and minimized. This is nutty. I run CAD, 3D Printing slicers, and much more and none of them run the CPU at 25%, ever.

Attached screenshot show VPS stats and even 21 Chrome tabs open which have almost zero CPU and very little RAM use.

To Reproduce install VPS run VPS look at Task Manager 'process tab'

Expected behavior nearly no CPU use when idle. maybe 10% when maxed?

Screenshots If applicable, add screenshots to help explain your problem.

Desktop AMD Ryzen 7 7735HS 8 core 16 thread 3.20 to 4.75Ghz Radeon Graphics iGPU
32 GB RAM Windows 10, all existing updated drivers and windows updates installed

Capture

syd711 commented 7 months ago

As mentioned on Discord, I have described the reason for this here: https://github.com/syd711/vpin-studio/wiki/Troubleshooting#why-does-the-studio-use-so-much-cpu

There isn't much I can do about this, so I hope you don't mind that I close this ticket.

Ltek commented 7 months ago

As mentioned on Discord, I have described the reason for this here: https://github.com/syd711/vpin-studio/wiki/Troubleshooting#why-does-the-studio-use-so-much-cpu

There isn't much I can do about this, so I hope you don't mind that I close this ticket.

Its been a long time (25 yrs) since I've coded so I'm not up on the best current ways but back then we'd would stop threads/processes/code-functions (network activity, media streaming/playing, etc) based on the state of the application window. I heard there are methods to have your app listen for OS events... window minimized, window maximized, window moved, etc

a quick search turned up...

https://stackoverflow.com/questions/4966194/how-could-i-detect-when-my-application-is-minimized

https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-isiconic

https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getwindowplacement?redirectedfrom=MSDN

syd711 commented 7 months ago

You are right. My answer was a bit sloppy. Sorry for that. I've seen "high CPU usage" and thought, "ah, yes, I know". Of course I can detect these states and will improve the CPU usage in these situation.

Ltek commented 7 months ago

thank you for being awesome. I'm one of 'those guys' ... my 30 year career I work with developers almost daily, I have not coded anything beyond pretty low-featured VBS, python, SQL, etc in 20yrs... and love when I meet a developer like yourself who builds great stuff and appreciates user suggestions. You app is fantastic... This could be a very nice replacement for Popper.

syd711 commented 7 months ago

Thank you! Your words are indeed much appreciated and this type of feedback is the reason that keeps me going. I really like to get all the feedback from the community and the ideas people come up with. I guess 90% of the feature and changes released in the last few month were community driven and its fun to shape these stuff together. Although the feedback quadrupled the last two weeks I hope keep it this way.

syd711 commented 7 months ago

Fixed. Will be part of the next "regular" update. I leave this ticket open until then so I don't forget to add the version number here.

syd711 commented 7 months ago

Fixed with 2.12.0