search

syd711 / vpin-studio

Competition, table, and player management for VPins.
MIT License
28 stars 2 forks source link

VPin-Studio.sh still not executable #24

Closed francisdb closed 7 months ago

francisdb commented 1 year ago

16 fixed the newlines but not the executable flag

Probably there is no way to keep this flag when cloning in windows?

francisdb commented 1 year ago

looking at https://github.com/syd711/vpin-studio/blob/553379ca2271f879353140422974fe1a4192da9f/vpin-studio-ui/pom.xml#L491-L502

I now understand why unzip does not see this file as a zip, it's actually a 7-zip file with zip instead of 7z extension.

unzip VPin-Studio-Client.zip
Archive:  VPin-Studio-Client.zip
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of VPin-Studio-Client.zip or
        VPin-Studio-Client.zip.zip, and cannot find VPin-Studio-Client.zip.ZIP, period.

I wonder if there's a way to let 7z know it should apply the executable flag.

syd711 commented 1 year ago

So 7z is the reason the flag gets lost? It wouldn't get lost when "regular" zip/unzip is used?

francisdb commented 1 year ago

So 7z is the reason the flag gets lost? It wouldn't get lost when "regular" zip/unzip is used?

Don't think so, I guess windows has no way to keep this flag so it's already lost at clone. Maybe some more standard maven plugin can do the zipping and has an option to set executable flag?

On a side note I would make sure the file is a true zip.

syd711 commented 7 months ago

Finally, I switched to "zip" so that this extraction error message is gone :) Regarding the executable flag: For me its just a corner case I don't want to focus on too much. So I'll close this ticket for now.