search

syd711 / vpin-studio

Competition, table, and player management for VPins.
MIT License
28 stars 2 forks source link

[Feature Request] Drag-n-Drop for non-media items: PUPs, ROMs, etc #276

Closed Ltek closed 3 months ago

Ltek commented 3 months ago

drag-n-drop doesnt work for: Tables, PUP packs, etc... only media. would be nice to not need to 'browse' every time.

image image

syd711 commented 3 months ago

Did you drop VPX or zip files into the table overview area? (as shown in the YouTube video ?) I've not tested with a NAS, but I don't think it will make difference.

The PUP pack dialog here is from version 2.20.0 while the screenshot of the table upload dialog is from version 2.19.0. So I'm not sure if something is mixed up here.

Ltek commented 3 months ago

I'm on 2.20 (I used an old screenshot). Opening the Upload dialog does not allow d-n-d, just shows a red circle with slash.

I'd suggest looking at consolidating all into a single method - remove the old upload button options and have a dedicated menu item / landing space, where a user drags the item to -- then have it always open the modal dialog to ask the user what they want to do.

also, when drag-n-drop a PUP ZIP to the main window, it does not ask the user if they want to upload to the highlighted table, or to a different table... like VPX does. Could this cause an issue that if the user doesnt have correct table highlighted or will it not matter since the PUP name will be whatever is in the ZIP? Capture

syd711 commented 3 months ago

I'm on 2.20 (I used an old screenshot). Opening the Upload dialog does not allow d-n-d, just shows a red circle with slash.

Ah, ok. I opened a separate ticket for this: https://github.com/syd711/vpin-studio/issues/277

syd711 commented 3 months ago

I'd suggest looking at consolidating all into a single method - remove the old upload button options and have a dedicated menu item / landing space, where a user drags the item to -- then have it always open the modal dialog to ask the user what they want to do.

This is what the upload already does. It seems emphasizing the current table selection like the way I do it currently is confusing. The selected table is only shown that if the dropped file is table related (e.g. a backglass) it is uploaded for the selected table. So the dropzone can remain where it is, but I should somehow visualize this better. The upload menu will remain for a better accessibility. But for mixed asset bundles (e.g. backglass and popper media) a separate dialog can be provided.

also, when drag-n-drop a PUP ZIP to the main window, it does not ask the user if they want to upload to the highlighted table, or to a different table... like VPX does. Could this cause an issue that if the user doesnt have correct table highlighted or will it not matter since the PUP name will be whatever is in the ZIP?

Yes, the path inside the archive determines where the PUP pack is uploaded. The selected table is not relevant for this. Same for ALTSound bundles.

syd711 commented 3 months ago

I've added the dnd option for the dialog and changed the table area dnd-overlay so that the current table info is not shown anymore which should lead to less confusing. The corresponding upload dialogs should show the actual upload details.

Solved with 2.20.1