syd711 / vpin-studio

Competition, table, and player management for VPins.
MIT License
31 stars 2 forks source link

[Bug] table csv export missing escaping #520

Open gorgatron1 opened 4 days ago

gorgatron1 commented 4 days ago

Describe the bug

table csv export missing escaping (I think)

To Reproduce

Consider this csv export. There are three tables that have corrupt CSV:

tables.csv

They have unquote semicolons e.g. in the Notes (gNotes) field:

number increases; next match will

Expected behavior

semicolons in text need to be quoted

gorgatron1 commented 4 days ago

Oh, it looks like it is a lot more -- I just noticed those when I sorted by year and the number of fields wasn't correct:

Very likely all the same issue

syd711 commented 1 day ago

The semicolons are escaped now using the escape character '\'. Quoting would be also possible, but the escape char felt more lightweight.