search

syd711 / vpin-studio

Competition, table, and player management for VPins.
MIT License
32 stars 2 forks source link

[Bug] VPS filtering not always consistent -- VPS data may be inconsistent #578

Closed gorgatron1 closed 1 week ago

gorgatron1 commented 1 week ago

Describe the bug

VPS filtering not always consistent -- VPS data may be inconsistent: a game may be missing its "features" even though the tables have them

To Reproduce

Consider "Shooting the Rapids":

In VPin Studio this does not show up under the VR filter, but it does on the VPS website:

image

It looks like VPin Studio uses the features on the game itself for the first pass of filtering, but that is not always a union of the individual entries. I noticed that there were a couple games where it showed under the VR feature but none of the tables had VR. Shooting the Rapids is the opposite: the table has it but it doesn't show using the VR filter in VPin Studio.

Expected behavior

I am not sure if it is a bug or a feature request but I expect that the filtering would honor the union of the features on the tables (at the game level) as it does on the website. I do think the VPS data is inconsistent, but maybe the game level feature data should be ignored and computed instead.

syd711 commented 1 week ago

Yes, we missed to analysize the features of all version here too.

syd711 commented 1 week ago

Fixed with 3.9.2