NVOffset validator is too strict - Githubissues

syd711 / vpin-studio

Competition, table, and player management for VPins.

MIT License

33 stars 2 forks source link

NVOffset validator is too strict #599

Closed gorgatron1 closed 5 days ago

gorgatron1 commented 5 days ago

Describe the bug

NVOffset validator is too strict -- complains about setting for two games for the same table

To Reproduce

Consider this:

I have 4 cc_13 tables:

Cactus Canyon Continued (LW), NVOffset=2 (selected in screenshot)
Cactus Canyon Continued (VPW), NVOffset=2
Cactus Canyon (VPW), NVOffset=2
Cactus Canyon (VPW + DarRDog), NVOffset=2

The validation shows: NVOffset = 2 but Cactus Canyon Continued (VPW) also has the NVOffset 2

In my opinion this is correct -- both games are for table https://virtualpinballspreadsheet.github.io/?game=gBpX0hxi&fileType=table so they should have the same NVOffset.

I think the uniqueness of NVOffset should be for:

same rom
different tables (game=XXX)

syd711 commented 5 days ago

Fixed with 3.10.1