search

sydsim / personlab-tf

implementation of PersonLab(https://arxiv.org/abs/1803.08225) using TF-slim
103 stars 19 forks source link

prediction_map_updating_twice #1

Closed noumanriazkhan closed 6 years ago

noumanriazkhan commented 6 years ago

At L120, kp_map_pred was again assigned with map constructed from 'tval' while this must be true_map not predicted.

sydsim commented 6 years ago

Thanks for revising my code! I really appriciate it. Updating kp_map_pred twice was my mistake. I forgot to remove the second updating line. But we don't have to contruct_keypoint_map on true values because it's already in true_tensor (and using the keypoint in true_tensor would be much accurate than calculating from heatmap and offset) I fixed the bug in master branch. Thanks again!

noumanriazkhan commented 6 years ago

Cool. So now since we are talking, let me mention a couple of other issues. You should update the training code: i) It throws OOM error if I change no of GPUs ii) It's not converging as fast as it's on your example notebook iii) Crashing after 15K+ epochs, I will open issue and paste details.