syedhali / EZAudio

An iOS and macOS audio visualization framework built upon Core Audio useful for anyone doing real-time, low-latency audio processing and visualizations.
Other
4.96k stars 824 forks source link

Crash when loading ipod-library:// urls #222

Open solomon23 opened 9 years ago

solomon23 commented 9 years ago

You used to be able to construct a EZAudioFile with an ipod-library:// URL. It looks like this commit now makes that crash:

https://github.com/syedhali/EZAudio/commit/62055f17823a3f7b7f11a0f375560a4535ed03f8

Specifically line 248: BOOL fileExists = [[NSFileManager defaultManager] fileExistsAtPath:fileURL.path];

There are really two issues. 1. That check should be removed so that ipod-library urls work again. 2. It shouldn't straight up crash when doing a dealloc

syedhali commented 9 years ago

Hmm, I'll look into this. I'm not sure how the iPod library urls were working at all in the previous version, but I'll see if the old code is still working and make some tweaks.

solomon23 commented 9 years ago

Thanks - I created a fork so my project could move forward : https://github.com/solomon23/EZAudio/tree/remove-file-check

Not sure if there are other repercussions to that. But it fixed my use case of loading a music track from the library and making a plot out of it.