Local Notification - Githubissues

syedmurtaza108 / chucker-flutter

An HTTP requests inspector inspired by Chucker Android

https://pub.dev/packages/chucker_flutter

MIT License

54 stars 32 forks source link

Local Notification #20

Closed mustofa-al closed 1 year ago

mustofa-al commented 1 year ago

Description

Hello @syedmurtaza108, i added local notification support, just like alice. But it still not possible for now to stack the notification like they did.

I updated the readme too for usage.

But, due to conflict to another plugin in my project, i downgrade the chopper version to 4.0.5.

Type of Change

[x] ✨ New feature: Local Notification

syedmurtaza108 commented 1 year ago

Salam @mustofa-al, the feature really looks amazing🥳. I will definitely look into this as soon as possible for me. Meanwhile I request you to add tests for this feature as I don't find any test.

Thank you for your contribution🙌

mustofa-al commented 1 year ago

Yeah i think i need to test how notification initialized & show as soon as possible, but could you guide me what else to test?

syedmurtaza108 commented 1 year ago

@mustofa-al By test I meant to add unit and widget tests for the feature. To get a basic idea of how to add tests, you may see https://github.com/syedmurtaza108/chucker-flutter/tree/master/test

mustofa-al commented 1 year ago

@syedmurtaza108 yeah i know. Wait, i'm working on

mustofa-al commented 1 year ago

@syedmurtaza108 hello, i'm done with my changes, but how to update changes to this pull request? or would be better to create new pull request?

syedmurtaza108 commented 1 year ago

@mustofa-al Thank you for updates.

You don't need to update changes in the PR. They are automatically reflected in the PR as soon as you make changes in your master branch.
I request you to plz create your PR again from dev branch instead of master. Because we will be releasing a beta version first for the public to check the stability of the feature before merging it to master branch.
After we get satisfied, we will merge it to master and I will make these changes public on pub.dev

syedmurtaza108 commented 1 year ago

This PR is being closed in respect of PR#21.