syedowaisali / crystal-range-seekbar

537 stars 164 forks source link

it has bug in setMaxStartValue() #65

Closed fan123199 closed 6 years ago

fan123199 commented 6 years ago
 private void setMaxStartValue() {
        if (maxStartValue < maxValue && maxStartValue > minValue && maxStartValue > minStartValue) {
            maxStartValue = Math.max(maxStartValue, absoluteMinValue);
            maxStartValue -= absoluteMinValue;
            maxStartValue = maxStartValue / (absoluteMaxValue - absoluteMinValue) * 100;
            setNormalizedMaxValue(maxStartValue);
        }
    }

line 2 ,maxStartValue = Math.max(maxStartValue, absoluteMinValue); should be

maxStartValue = Math.max(maxStartValue, absoluteMaxValue);

reyanshmishra commented 6 years ago

I think its not the solution I just tried it didn't work.

fan123199 commented 6 years ago

@reyanshmishra sorry, this issue is no longer useful when lib verion upon 1.1.3. I will close it. I use 1.1.3 and get expected result.