syedowaisali / crystal-range-seekbar

537 stars 164 forks source link

Remove "absolute" min/max start values on range seekbar #82

Open mattstanford opened 6 years ago

mattstanford commented 6 years ago

Fixes #69

At first my solution for this was to initialize the "absoluteMinStartValue" and "absoluteMaxStartValue" variables to their counterpart that was passed in through the style attributes in the init() function.

However when I looked deeper into it, it does not appear to me that these "absolute" values are necessary, the passed in values work just the same. Once the "absolute" values are gone there doesn't have to be any issues of initialization.

I see that there was a commit here regarding the "absolute" values: https://github.com/syedowaisali/crystal-range-seekbar/commit/bc8b671ff038ff2aa765c7186ace208b0d37e5e0 . I tested programmatically setting the max and min start values and it still works (as well as setting them via XML).