droprate is a 0-1 scale; use 1.0 for failure

syepes / network_exporter

ICMP / Ping & MTR & TCP Port & HTTP Get - Network Prometheus exporter

Apache License 2.0

329 stars 59 forks source link

droprate is a 0-1 scale; use 1.0 for failure #5

Closed mattmichal closed 3 years ago

mattmichal commented 3 years ago

DropRate is calculated on a 0.0 to 1.0 scale when an ICMP is successful. If it's a failure, the DropRate should be set to 1.0 instead of 100.0 so that the scale remains the same in all cases.

syepes commented 3 years ago

Great suggestion, I completely missed that the other values were already using the range 0.0-1.0. Thanks