search

sygmaprotocol / docs

Documentation for Sygma
https://docs.buildwithsygma.com
3 stars 1 forks source link

chore: update feeHandlers #159

Closed tcar121293 closed 3 months ago

tcar121293 commented 3 months ago

Description

For the reference, this are the new changes

tcar121293 commented 3 months ago

thanks for updating all of the contract addresses @tcar121293 🙏 a few changes requested:

  • naming the duplicated Dynamic Fee Handler's differently in the Sepolia section
  • not sure if it's too late, but where possible, pls verify all new contracts that get deployed 🙇
  • some of the contract addresses don't seem like actual deployed contracts, more like untouched EOAs. ive tried highlighting them all with a comment.
  • the Amoy section contains all broken links to the OKLink block explorer. ive provided the amended hyperlinks if you could pls replace them 🙏
  • small spelling corrections

thank you so much!!!

I resolved most of the issues. Only thing that is left is the verification issues. We have a known issue with verifying contracts on cronos. I was also unable to verify percentage fee handler on some of the networks. and gmp handler on the b3-sepolia. I think we can close this docs PR, and handle the verification of the contracts later

haochizzle commented 3 months ago

sgtm!