feat: shared config endpoint

sygmaprotocol / sygma-explorer-indexer

Backend service that collects bridging events for bridging explorer ui

GNU Lesser General Public License v3.0

3 stars 2 forks source link

feat: shared config endpoint #212

Closed wainola closed 1 month ago

wainola commented 2 months ago

Description

provides endpoint to get shared config hosted on S3

Related Issue Or Context

Closes: #213

How Has This Been Tested? Testing details.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have ensured that all acceptance criteria (or expected behavior) from issue are met
[ ] I have updated the documentation locally and in chainbridge-docs.
[ ] I have added tests to cover my changes.
[ ] I have ensured that all the checks are passing and green, I've signed the CLA bot

wainola commented 2 months ago

Add reamining icons url from explorer

wainola commented 2 months ago

@wainola Isn't now /domains/metadata essentially returning also all information that you would get from a new endpoint /domains/:domainID/resources for fetching resources for a domain?

I would rather then have domains/metadata omit resources if we have separate endpoint, wdyt?

This was something I wanted to discuss actually. I have resources in a separate object, so this domainMetadata can remain only as domain wise information and then per domain id, we query to get the resources. It makes sense from a resource access point of view. It will only mean we have two objects with similar shape, but one of them is just domain info, and the other is resource info per domain.

wainola commented 2 months ago

@wainola Isn't now /domains/metadata essentially returning also all information that you would get from a new endpoint /domains/:domainID/resources for fetching resources for a domain? I would rather then have domains/metadata omit resources if we have separate endpoint, wdyt?

This was something I wanted to discuss actually. I have resources in a separate object, so this domainMetadata can remain only as domain wise information and then per domain id, we query to get the resources. It makes sense from a resource access point of view. It will only mean we have two objects with similar shape, but one of them is just domain info, and the other is resource info per domain.

resolved

MakMuftic commented 2 months ago

Does it make sense to add a URL for resource icons @wainola ?

wainola commented 2 months ago

Does it make sense to add a URL for resource icons @wainola ?

Added icons

wainola commented 1 month ago

Let us just open PR on widget to change property name so it doesn't brake

issue already created