Test improvements - Githubissues

sygmaprotocol / sygma-sdk

A Typescript SDK to add cross-chain capabilities such as bridging tokens and sending messages across dApp projects.

https://docs.buildwithsygma.com/

GNU Lesser General Public License v3.0

31 stars 19 forks source link

Test improvements #390

Closed wainola closed 3 weeks ago

wainola commented 2 months ago

This is a nice to have. Currently in some of our test for substrate we have a lot of repetitive code mocking the ApiPromise instance. It could be good for readability purposes to have a global mocked instance of ApiPromise to which we pass the parameters from the test.

Implementation details

Improve code on current test:

mock ApiPromise as module to avoid repeating into the test

Testing details

Acceptance Criteria

QA Details

MakMuftic commented 1 month ago

Hey team! Please add your planning poker estimate with Zenhub @saadjhk @wainola @Lykhoyda

wainola commented 1 month ago

@MakMuftic I would like to close this in favour of #410, wdyt?

MakMuftic commented 3 weeks ago

We created separate issues per network type