sygmaprotocol / sygma-sdk

A Typescript SDK to add cross-chain capabilities such as bridging tokens and sending messages across dApp projects.
https://docs.buildwithsygma.com/
GNU Lesser General Public License v3.0
32 stars 21 forks source link

feat(evm): Update SDK to Support New ERC20Handler with Optional Contract Call #504

Closed saadahmsiddiqui closed 1 month ago

saadahmsiddiqui commented 2 months ago

Implementation details

With the introduction of the new ERC20Handler, the SDK needs to be updated to handle the enhanced functionality that supports both ERC20 token transfers and optional contract calls in a single transaction. New ERC20Handler PR

Closes: #493

Testing details

Acceptance Criteria

lastperson commented 2 months ago

Overall correct, though on the contracts side optionalGas if included must be accompanied by the optionalMessage, otherwise contract call would not happen. So allowing users to only include gas might create a false impression that it affects anything.