search

sygmaprotocol / sygma-widget

Transfer widget for the sygmaprotocol
5 stars 2 forks source link

Field validation for substrate destination is not done #115

Closed LyonSsS closed 4 months ago

LyonSsS commented 4 months ago

Severity: High | Priority: High

Context: When a user will transfer from Source EVM to destination Substrate, field validation for the "Send To" wallet field, is only applied to EVM format and not to substrate one.

STR:

  1. Select From as Sepolia
  2. Connect metmask wallet
  3. Select destination as Rococ-phala
  4. Select sygUSDC as ERC20 token.
  5. Input a transfer amount <= max;
  6. Input in"Send To" wallet field an EVM address.

Exp: The field should be validated on substrate format and display the invalid format. Act: The field is only validated against EVM format and allowed the transfer to continue. image image

wainola commented 4 months ago

@LyonSsS deployed UI is ready to be reviewed

LyonSsS commented 4 months ago

Tested on PR branch: image image image Validated with multiple substrate formats from : https://polkadot.subscan.io/tools/format_transform This issue is closed