search

sygmaprotocol / sygma-widget

Transfer widget for the sygmaprotocol
5 stars 2 forks source link

User is not notified if the transfer fails #116

Open LyonSsS opened 4 months ago

LyonSsS commented 4 months ago

Severity: Medium | Priority: Medium

Note: If there is a failure in the transfer flow, the user will not going to get notified.

STR:

  1. Create an E2E flow from EVM to Substrate.
  2. Pass an incompatible Substrate address.
  3. Finalize transfer flow.
  4. Transfer fails at execution on substrate.

Exp: The user to be informed somehow that his transfer failed at maturity. Act: The user has no clue, other than the scan that the transfer failed.

image

MakMuftic commented 4 months ago

Hey team! Please add your planning poker estimate with Zenhub @Lykhoyda @mpetrunic @wainola

wainola commented 4 months ago

@mpetrunic do we need some design updates for this?

mpetrunic commented 4 months ago

@MakMuftic @LyonSsS I think this is out of scope for 0.x as we would need indexer feature for that.

@LyonSsS What is the incompatible substrate address?

MakMuftic commented 4 months ago

We have this already @mpetrunic, also added to the SDK here.

It doesn't provide a detailed reason of failure, but returns transfer state: 'pending' | 'executed' | 'failed'

LyonSsS commented 4 months ago

In this scenario I profited about the UI design to send EVM address for Substrate destination, which failed. Scope was to fail execution ... but it can be replicated with Relayer Issues OR not having enough funds on destination to execute proposal ... so the flow has potential. In terms of UI, this seems like an improvement and we can scope it for next iteration. Might move it to a feature this instead of a bug. @mpetrunic

mpetrunic commented 4 months ago

I would move it into new feature for next cycle as we need different designs for that^^