fix: switch networks and misc fixes - Githubissues

sygmaprotocol / sygma-widget

Transfer widget for the sygmaprotocol

5 stars 2 forks source link

fix: switch networks and misc fixes #127

Closed wainola closed 3 months ago

wainola commented 4 months ago

Description

Related Issue Or Context

Closes: #111 #119 #118 #112

How Has This Been Tested? Testing details.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have ensured that all acceptance criteria (or expected behavior) from issue are met
[ ] I have updated the documentation locally and in sygma-docs.
[ ] I have added tests to cover my changes.
[ ] I have ensured that all the checks are passing and green, I've signed the CLA bot

mpetrunic commented 3 months ago

@wainola Here is PR to address the problem causing bugs -> we weren't handling/notifying parent components that selected resource is undefined because out handlers had incorrect signatures

https://github.com/sygmaprotocol/sygma-widget/pull/138