Source network gets reset on starting new transfer

sygmaprotocol / sygma-widget

Transfer widget for the sygmaprotocol

5 stars 2 forks source link

Source network gets reset on starting new transfer #133

Closed mpetrunic closed 3 months ago

mpetrunic commented 4 months ago

Expected Behavior

If wallet is still connected we shouldn't reset selected source network.

Current Behavior

We reset selected source network which ends us in unsupported state where wallet is connected before source network is selected

Possible Solution

Steps to Reproduce (for bugs)

1. 2. 3. 4.

Version

Sygma commit (or docker tag): sygma-solidity version: sygma-substrate version: Go version:

LyonSsS commented 4 months ago

From my point of view, since the specifications and also Figma design flow, do not specify this behavior, I do consider that a "starting a new transfer" = "initial transfer". Because of this, I do consider the behavior as normal. I would be glad with booth ways - restart OR keep the user historical data as it was before ( Source). I think this can be of course answered by product. CC: @itsbobbyzzz168

mpetrunic commented 4 months ago

I think question is do we disconnect wallet as well or do we leave source network selected and remove everything else. As those are only two valid states for widget

Right now wallet remains connected while source network is not selected which we agreed on not supporting (selecting source network is condition for connecting wallet)

LyonSsS commented 2 months ago

Teste on PR link