fix: evm amount is now calculated as user input minus the fee - Githubissues

sygmaprotocol / sygma-widget

Transfer widget for the sygmaprotocol

5 stars 2 forks source link

fix: evm amount is now calculated as user input minus the fee #143

Closed mpetrunic closed 3 months ago

mpetrunic commented 3 months ago

Description

Related Issue Or Context

Closes: #139

How Has This Been Tested? Testing details.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have ensured that all acceptance criteria (or expected behavior) from issue are met
[ ] I have updated the documentation locally and in sygma-docs.
[ ] I have added tests to cover my changes.
[ ] I have ensured that all the checks are passing and green, I've signed the CLA bot

mpetrunic commented 3 months ago

~~Depends on: https://github.com/sygmaprotocol/sygma-sdk/pull/360~~

mpetrunic commented 3 months ago

~~This is blocked until, testnet fee handlers are deployed to use latest smart contracts~~

mpetrunic commented 3 months ago

~~depends on https://github.com/sygmaprotocol/sygma-sdk/pull/365~~