sygmaprotocol / sygma-widget

Transfer widget for the sygmaprotocol
5 stars 2 forks source link

feat: Display Fee #145

Closed saadjhk closed 3 months ago

saadjhk commented 3 months ago

This PR adds UI in widget to display fee that will be charged on FungibleTransfer

Description

Related Issue Or Context

https://github.com/sygmaprotocol/sygma-widget/issues/55

Closes: #55

How Has This Been Tested? Testing details.

Types of changes

Checklist:

Lykhoyda commented 3 months ago

@saadjhk It will be nice also to have the font sizes as per design here: (https://www.figma.com/file/T3A0opRIH07hSqUaESKgFV/Sygma-Widget-UI?type=design&node-id=285-5497&mode=dev) And the label "Bridge fee" is more informative than just "fee". Can you please align with the design?

Screenshot 2024-03-19 at 13 37 45
Lykhoyda commented 3 months ago

⚠️ To be merged before this PR https://github.com/sygmaprotocol/sygma-widget/pull/149

Lykhoyda commented 3 months ago

@saadjhk it gets stuck with the error "Failed getting fee", so I couldn't test the entire UI. Is it expected for now, can you please take a look?

Screenshot 2024-03-26 at 15 48 54
saadjhk commented 3 months ago

@

@saadjhk it gets stuck with the error "Failed getting fee", so I couldn't test the entire UI. Is it expected for now, can you please take a look?

Screenshot 2024-03-26 at 15 48 54

seems like a sdk level error, there is no error handling on fetching fee so routes with no fee configuration must throw this error. However, I'm not sure if that should be handled in this PR

mpetrunic commented 3 months ago

@

@saadjhk it gets stuck with the error "Failed getting fee", so I couldn't test the entire UI. Is it expected for now, can you please take a look?

Screenshot 2024-03-26 at 15 48 54

seems like a sdk level error, there is no error handling on fetching fee so routes with no fee configuration must throw this error. However, I'm not sure if that should be handled in this PR

Please open issue on sdk repo!