chore: changes from dev into main

sygmaprotocol / sygma-widget

Transfer widget for the sygmaprotocol

5 stars 2 forks source link

chore: changes from dev into main #183

Closed wainola closed 6 months ago

wainola commented 6 months ago

Description

Bringing changes from dev into main

Related Issue Or Context

Closes: #

How Has This Been Tested? Testing details.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have ensured that all acceptance criteria (or expected behavior) from issue are met
[ ] I have updated the documentation locally and in sygma-docs.
[ ] I have added tests to cover my changes.
[ ] I have ensured that all the checks are passing and green, I've signed the CLA bot

mpetrunic commented 6 months ago

Please do not merge, once approved, I will create merge commit on main branch^^

wainola commented 6 months ago

please double check the code changes, I spotted that the bug fix from https://github.com/sygmaprotocol/sygma-widget/pull/176/files was almost everywhere reverted to the state of the dev branch. I'm not sure about other stories, but it worth to check again

I restore last missing changes that were badly overwritten

Lykhoyda commented 6 months ago

@wainola deployed version https://d633b65c.sygma-widget.pages.dev/ has infinite loader, something is wrong with initSdk state probably

wainola commented 6 months ago

@wainola deployed version https://d633b65c.sygma-widget.pages.dev/ has infinite loader, something is wrong with initSdk state probably

fixed @Lykhoyda

Lykhoyda commented 6 months ago

@wainola have you been able to finish the transfer? For me, it stuck on the: cannot estimate gas; transaction may fail or may require manual gas limit

wainola commented 6 months ago

@wainola have you been able to finish the transfer? For me, it stuck on the: cannot estimate gas; transaction may fail or may require manual gas limit

@Lykhoyda solved, could you re-test on your side?