search

sygmaprotocol / sygma-widget

Transfer widget for the sygmaprotocol
5 stars 2 forks source link

Transfer from EVM to Polkdaot chains, using an invalid destination format, it is still possible #189

Closed LyonSsS closed 5 months ago

LyonSsS commented 6 months ago

Context: When a user use the widget, to transfer from EVM to Substrate, the only address allowed to be paste as destination, should be a Substrate valid format one. If the user passes an incorrect format, the transfer should be blocked.

STR:

  1. Connect an EVM wallet and select source to Sepolia.
  2. Select destination to Rococo-Phala.
  3. Select SygUSDC from the token drop-down.
  4. Fill in a value in the amount to transfer ( > 0 and <= max value)
  5. Paste an invalid format ( an EVM address) to the "Send to" field.
  6. Wait 3 seconds.

Exp: Nothing to happen. The button that allows to allow spending and then transfer, to not be enabled. Act: The buttons that allow the flow to move forward are enabled ( allow spending and transfer)

image

LyonSsS commented 5 months ago

Verified on PR https://github.com/sygmaprotocol/sygma-widget/pull/197 image image image