feat: address to transfer

sygmaprotocol / sygma-widget

Transfer widget for the sygmaprotocol

5 stars 2 forks source link

feat: address to transfer #56

Closed wainola closed 7 months ago

wainola commented 7 months ago

Description

This PR adds toggle and input to introduce address to transfer

Related Issue Or Context

Closes: #20

How Has This Been Tested? Testing details.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have ensured that all acceptance criteria (or expected behavior) from issue are met
[ ] I have updated the documentation locally and in sygma-docs.
[ ] I have added tests to cover my changes.
[ ] I have ensured that all the checks are passing and green, I've signed the CLA bot

cloudflare-pages[bot] commented 7 months ago

Deploying with Cloudflare Pages

Latest commit:	`8d9b1be`
Status:	✅ Deploy successful!
Preview URL:	https://6e527855.sygma-widget.pages.dev
Branch Preview URL:	https://feat-address-to-transfer.sygma-widget.pages.dev

View logs

mpetrunic commented 7 months ago

it might make sense to rebase against: https://github.com/sygmaprotocol/sygma-widget/pull/62 so you can add address input tests.

wainola commented 7 months ago

it might make sense to rebase against: #62 so you can add address input tests.

sure, I'm going to do it

mpetrunic commented 7 months ago

@wainola Can you put this component inside widget?

wainola commented 7 months ago

@wainola Can you put this component inside widget?

it is, I haven't pushed that. Will do shortly

mpetrunic commented 7 months ago

@wainola since we still don't have designs for error states, could you just:

make error message font smaller and less bold
make sure it doesn't move components around when displayed
ensure it aligns with right side
maybe make message lowercase?

Also I think input border is too accented when focused and input text font is bigger in the design

wainola commented 7 months ago

@wainola since we still don't have designs for error states, could you just:

make error message font smaller and less bold

make sure it doesn't move components around when displayed

ensure it aligns with right side

maybe make message lowercase?

Also I think input border is too accented when focused and input text font is bigger in the design

Fixed, although we still should have a theming/style issue once we have everything there, to check changes on size when widget is connected

mpetrunic commented 7 months ago

@wainola One small issue, when error message shows it pushes input field down. Could you ensure this doesn't happen (align message on the right side of the input field)