feat: base interface implementation for react package

sygmaprotocol / sygma-widget

Transfer widget for the sygmaprotocol

5 stars 2 forks source link

feat: base interface implementation for react package #61

Closed wainola closed 7 months ago

wainola commented 7 months ago

Description

Related Issue Or Context

Closes: #10

How Has This Been Tested? Testing details.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have ensured that all acceptance criteria (or expected behavior) from issue are met
[ ] I have updated the documentation locally and in sygma-docs.
[ ] I have added tests to cover my changes.
[ ] I have ensured that all the checks are passing and green, I've signed the CLA bot

cloudflare-pages[bot] commented 7 months ago

Deploying with Cloudflare Pages

Latest commit:	`492eae4`
Status:	✅ Deploy successful!
Preview URL:	https://9c50080d.sygma-widget.pages.dev
Branch Preview URL:	https://feat-react-package.sygma-widget.pages.dev

View logs

wainola commented 7 months ago

@mpetrunic since in the meantime the react package is using the widget from the workspace, do we care if the pipeline for the linter is failing because it can't find the dependency, since afaik is just linting and building that package?

mpetrunic commented 7 months ago

@mpetrunic since in the meantime the react package is using the widget from the workspace, do we care if the pipeline for the linter is failing because it can't find the dependency, since afaik is just linting and building that package?

nope :) fixed ci

wainola commented 7 months ago

could you also add demo react app that uses @buildwithsygma/sygmaprotocol-react-widget and change cd to deploy that react page on cloudflare?

@mpetrunic done, I made some changes on the name of some of the build scripts to have more granular control over the builds