search

sygmaprotocol / sygma-widget

Transfer widget for the sygmaprotocol
5 stars 2 forks source link

feat: amount input styles update #77

Closed Lykhoyda closed 5 months ago

Lykhoyda commented 5 months ago

Closes: #67

⚠️ this part of the story is not implemented due to hardcoded data (moved to the separate issue #78 )

on resource selected, wallet balance should be presented refresh balance periodically

Lykhoyda commented 5 months ago
  • When validation fails, it probably makes sense for entire section border to be red?
  • In the design, selected token is gray pill
  • amount input font seems to be to bold/big (cc @sweetpea22 ). Maybe make by default smaller but also we could make font smaller depending on input size?
  • can we not have input border when inputting (or at least less visible)

All fixed, thank you for the review!

Lykhoyda commented 5 months ago

also, it'd be good to close dropdown on click outside of it, as most users think of this as default UX

and to avoid this case too image

I'm glad Marin had a quick solution for that 😅

sztok7 commented 5 months ago

@Lykhoyda all good, just please merge this https://github.com/sygmaprotocol/sygma-widget/pull/83 first :)

wainola commented 5 months ago

@Lykhoyda you will need to merge main to this branch since is outdated 😄

Lykhoyda commented 5 months ago

LGTM but you need to add tests for amount selector^^

Added the tests 👍