sygmaprotocol / sygma-widget

Transfer widget for the sygmaprotocol
5 stars 2 forks source link

Enable adding other web3 wallets #87

Closed mpetrunic closed 3 months ago

mpetrunic commented 5 months ago

Implementation details

We should enable users to configure other wallets in Onboard library.

Testing details

Acceptance Criteria

saadjhk commented 3 months ago

@mpetrunic @MakMuftic do we have a list of wallets that we would want to enable w.r.t priorities

itsbobbyzzz168 commented 3 months ago

@saadjhk yes, list of wallets below:

EVM

  1. metamask
  2. Wallet Connect

Substrate

  1. Polkadot.js
  2. Talisman
  3. Nova wallet

Overall order

  1. Metamask
  2. Polkadot.jjs
  3. Talisman
  4. Wallet connect/Nova
itsbobbyzzz168 commented 3 months ago

Also we realised this ticket is just EVM focused, so the scope of this ticket is just

EVM

  1. metamask
  2. wallet connect

@saadjhk

mpetrunic commented 3 months ago

Hey @saadjhk the goal is just enable user to pass https://github.com/blocknative/web3-onboard/blob/develop/packages/core/src/types.ts#L25 so they can install/enable any wallet supported by the library

saadjhk commented 3 months ago

@LyonSsS you would be able to verify this by providing your own wallet modules to SygmaWidget compoent

itsbobbyzzz168 commented 3 months ago

@saadjhk hi ser, just for visibility if needing QA, just easier if you add label plus move it into QA and then will see it straight away Screenshot 2024-04-15 at 14.00.45.png

saadjhk commented 3 months ago

@itsbobbyzzz168 got it 👍🏻

LyonSsS commented 3 months ago

Tested on branch https://github.com/sygmaprotocol/sygma-widget
I added a few wallets for test:

image.png

All of them work but some of the integrations from "onboard" may require extra set-up.

image.png image.png image.png image.png image.png

Some fails: Ledger has some error issue reporting

image.png

Trezor also has some issues:

image.png

MEW also has some issues

image.png

The issues are related to the "onboard" libraries and are not subject to this ticket. Closking this one