Closed mpetrunic closed 3 months ago
@mpetrunic @MakMuftic do we have a list of wallets that we would want to enable w.r.t priorities
@saadjhk yes, list of wallets below:
EVM
Substrate
Overall order
Also we realised this ticket is just EVM focused, so the scope of this ticket is just
EVM
@saadjhk
Hey @saadjhk the goal is just enable user to pass https://github.com/blocknative/web3-onboard/blob/develop/packages/core/src/types.ts#L25 so they can install/enable any wallet supported by the library
@LyonSsS you would be able to verify this by providing your own wallet modules to SygmaWidget
compoent
@saadjhk hi ser, just for visibility if needing QA, just easier if you add label plus move it into QA and then will see it straight away
@itsbobbyzzz168 got it 👍🏻
Tested on branch https://github.com/sygmaprotocol/sygma-widget
I added a few wallets for test:
All of them work but some of the integrations from "onboard" may require extra set-up.
Some fails: Ledger has some error issue reporting
Trezor also has some issues:
MEW also has some issues
The issues are related to the "onboard" libraries and are not subject to this ticket. Closking this one
Implementation details
We should enable users to configure other wallets in Onboard library.
Testing details
Acceptance Criteria