syj02 / pe

0 stars 0 forks source link

Error in deletemaintrip when there are multiple trips that contain the same string of characters #6

Open syj02 opened 6 months ago

syj02 commented 6 months ago

I have 2 trips, "EuropeTrip" and "EuropeTrip2". Deleting "EuropeTrip" caused "EuropeTrip2" to be not found. It also led to an error in the trips list. Did not add another trip named "!!!!" but now I have 2 trips of this name.

Screenshot 2024-04-19 at 16.38.45.png

Screenshot 2024-04-19 at 16.39.01.png

Screenshot 2024-04-19 at 16.40.23.png

soc-pe-bot commented 6 months ago

Team's Response

Sorry we were not able to reproduce this bug, perhaps there are white spaces in your command 'deletemaintrip /n EuropeTrip2' which the app could not match to the actual trip EuropeTrip2. 1.png 2.png 4.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.CannotReproduce]

Reason for disagreement: 1. addmaintrip /n EuropeTrip /start 2024-05-01 /end 2024-05-14 /location Europe /d Holiday and list

Screenshot 2024-04-25 at 14.25.23.png

  1. addmaintrip /n EuropeTrip2 /start 2024-05-15 /end 2024-05-31 /location Asia /d Holiday1 and list

Screenshot 2024-04-25 at 14.25.41.png

  1. addmaintrip /n test /start 2024-06-01 /end 2024-06-14 /location Canada /d Holiday2 and list

Screenshot 2024-04-25 at 14.26.04.png

  1. addmaintrip /n test2 /start 2024-06-15 /end 2024-06-30 /location US /d Holiday3 and list

Screenshot 2024-04-25 at 14.26.38.png

  1. deletemaintrip /n EuropeTrip and list

Screenshot 2024-04-25 at 14.26.55.png

In the above example, there is a duplicate of test and missing EuropeTrip2 after deleting EuropeTrip.

Another similar example of the bug above

  1. addmaintrip /n test /start 2024-05-01 /end 2024-05-14 /location Europe /d Holiday
  2. addmaintrip /n testa /start 2024-05-15 /end 2024-05-31 /location Asia /d Holiday1
  3. addmaintrip /n testb /start 2024-06-01 /end 2024-06-14 /location Canada /d Holiday2
  4. addmaintrip /n testc /start 2024-06-15 /end 2024-06-30 /location US /d Holiday3 and list
  5. deletemaintrip /n test and list

Screenshot 2024-04-25 at 14.31.56.png

Screenshot 2024-04-25 at 14.32.39.png

Similarly, missing testa and duplicate of testb after deleting test.

From observations, this bug may occur when there are at least 4 trips, with 1 trip containing the exact string of the name of another trip (Example: test and testa) and it triggers this bug when these 2 trips are back-to-back.