syky27 / LunchGuy

A simple application for retrieving lunch menus of selected restaurants around FIT CTU
http://obedar.fit.cvut.cz/
12 stars 5 forks source link

Project cleanup #15

Closed josefdolezal closed 7 years ago

josefdolezal commented 7 years ago

Hey @syky27, as mentioned in #11, I did some cleanup at the project:

~Since not everything is done, marked the PR as WIP.~ Feel free to add comments and/or proposals. When this PR is merged, issues #8, #11 and #12 may be closed.

syky27 commented 7 years ago

I would not fix this: Fix commit messages to match repo style for now...

syky27 commented 7 years ago

CI tries to run this: Installing Pods with 'bundle exec pod install'

That is nonsense, no idea where its coming from...

syky27 commented 7 years ago

👌 VIP

josefdolezal commented 7 years ago

Hey @syky27, I removed the SwiftJSON after all - it was not easy, but not that hard as I thought. I also added back the headers for meal categories..

AJTYBot commented 7 years ago
1 Warning
:warning: You might want to include a CHANGELOG entry.

Generated by :no_entry_sign: Danger

syky27 commented 7 years ago

I believe this should be build passing commit, when it passes, I will squash my CI: commits.

And I would like to to ask you to refactor commit messages to match repo style, when I am done.

Thanks @josefdolezal

josefdolezal commented 7 years ago

Hey @syky27, I rebased the commits - all todos are now done! Once the CI succeeds, it should be ready for merge.