syky27 / LunchGuy

A simple application for retrieving lunch menus of selected restaurants around FIT CTU
http://obedar.fit.cvut.cz/
12 stars 5 forks source link

Integrate maps view as an alternative to restaurants list #16

Closed josefdolezal closed 7 years ago

josefdolezal commented 7 years ago

Hey @syky27! I would like to open discussion about map of restaurants from obedar API.

Context

I am using LunchGuy few times a week and usually, I check only one or two restaurants, since I don't know where the rest of them is located. It would be nice to have:

1) Map view with all restaurants from API 2) Possibility to open restaurant in Google Maps/Apple Maps from menu (for details like ratings, web site, phone numbers, ...)

Proposal

Create new LocationProvider protocol which will return CLLocationCoordinate2D for given restaurant. I saw tomaskadlec/lunch_guy#54 and tomaskadlec/lunch_guy#58 and I know that it's not currently implemented at backend. However, the list of restaurants has now less than twenty items, so we can create static provider. It would simply match restaurant by its name and return coordinates from hardcoded set. Once the backend implements this feature, we can just swap implementation of LocationProvider.

The UI would contain:

1) Navigation bar item in restaurant list, which would switch between map view and list view

What do you think?

syky27 commented 7 years ago

I totally agree

syky27 commented 7 years ago

But #4 is more pressing matter right now...

josefdolezal commented 7 years ago

Yeah, I was also thinking about it. Since we removed most of the dependencies in last PR, I think it will be enough to just mention and link Alamofire, Fabric and Crashlytics from README. So it mostly depends on #13.

cc @hroncok

syky27 commented 7 years ago

I believe that it needs to be mentioned inside the app to comply with those Licenses....

Tomas Sykora

On 26 Oct 2017, at 23:26, Josef Doležal notifications@github.com wrote:

Yeah, I was also thinking about it. Since we removed most of the dependencies in last PR, I think it will be enough to just mention and link Alamofire, Fabric and Crashlytics from README. So it mostly depends on #13 https://github.com/syky27/LunchGuy/issues/13.

cc @hroncok https://github.com/hroncok — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/syky27/LunchGuy/issues/16#issuecomment-339805873, or mute the thread https://github.com/notifications/unsubscribe-auth/ACpLWihj8OUeW2CauQ0e6UChu7VBbHYGks5swPkAgaJpZM4QIO1d.

hroncok commented 7 years ago

Your are slipping from the topic of this issue ;)