search

syky27 / LunchGuy

A simple application for retrieving lunch menus of selected restaurants around FIT CTU
http://obedar.fit.cvut.cz/
12 stars 5 forks source link

Adds strings localization #24

Closed josefdolezal closed 6 years ago

josefdolezal commented 6 years ago

This PR introduces CZ/EN localization discussed in #22. All hardcoded strings are now replaced with localized strings based on user's phone preferences.

Localization string keys are converted to name-spaced enum to ensure compile-time check of strings validity. The enums are generated with SwiftGen using aggregated Xcode target.

I have also added Danger action, which checks whether both languages are updated together.

✅ The README is updated.

syky27 commented 6 years ago

Why did those images got replaced?

AJTYBot commented 6 years ago
1 Warning
:warning: You might want to include a CHANGELOG entry.

Generated by :no_entry_sign: Danger

josefdolezal commented 6 years ago

Uh, I forgot to mention it! I move all app Resources (assets catalog, splash screen story board and configuration plist) into Resources group - It makes the project structure cleaner.

It also looks like Travis is failing again for some reason.. o.O

syky27 commented 6 years ago

No idea, why travis is failing those build logs are sometimes hell...

josefdolezal commented 6 years ago

This is really weird, it works just fine on my laptop..

josefdolezal commented 6 years ago

Cool, it works with new Xcode, I will squash the CI commits and it's ready to merge.