Core tests failing for all newer PRs due to wrong layer loading order

smile13241324 commented 6 years ago

Description :octocat:

It seems that the layer loading order is broken. This is causing the test test-declare-layers--distribution-layer-is-second to fail for all newer PRs.

Reproduction guide :beetle:

Start Emacs
Change to develop branch
Run tests/core/core-configuration-layer-utest.el on circle ci
Notice the failing core test, happening even when no changes have been done

Observed behaviour: :eyes: :broken_heart: The tests fail, preventing any merges.

Expected behaviour: :heart: :smile: The tests do not fail, allowing merges.

System Info :computer:

OS: gnu/linux
Emacs: 25.3.1
Spacemacs: 0.300.0
Spacemacs branch: develop (rev. d4017b1c)
Graphic display: t
Distribution: spacemacs
Editing style: vim
Completion: helm

Layers:

((helm :variables helm-enable-auto-resize t)
nim scheme
(auto-completion :variables auto-completion-return-key-behavior 'complete auto-completion-tab-key-behavior 'cycle auto-completion-complete-with-key-sequence nil auto-completion-complete-with-key-sequence-delay 0.0 auto-completion-private-snippets-directory nil auto-completion-enable-snippets-in-popup t auto-completion-enable-help-tooltip t auto-completion-enable-sort-by-usage t)
better-defaults
(clojure :variables clojure-enable-fancify-symbols t)
gpu graphviz
(plantuml :variables plantuml-jar-path "~/.plantuml/plantUml.jar" org-plantuml-jar-path "~/.plantuml/plantUml.jar")
salt ibuffer emacs-lisp pdf-tools cscope gtags
(org :variables org-want-todo-bindings t org-enable-github-support t org-enable-bootstrap-support t org-enable-reveal-js-support t org-enable-hugo-support t)
(shell :variables shell-enable-smart-eshell t shell-default-shell 'ansi-term shell-default-height 30 shell-default-position 'bottom shell-default-full-span nil shell-default-term-shell "/usr/bin/fish" syntax-checking)
version-control semantic themes-megapack
(c-c++ :variables c-c++-default-mode-for-headers 'c++-mode c-c++-enable-clang-support t c-c++-enable-clang-format-on-save t)
(cmake :variables cmake-enable-cmake-ide-support t)
git github sml pass common-lisp
(python :variables python-test-runner 'pytest python-enable-yapf-format-on-save t python-sort-imports-on-save t)
windows-scripts agda jr shell-scripts prodigy emoji
(markdown :variables markdown-live-preview-engine 'vmd)
bibtex
(latex :variables latex-enable-auto-fill t latex-enable-magic nil latex-enable-folding t)
lua html
(javascript :variables javascript-disable-tern-port-files nil)
react yaml nginx docker csv search-engine
(restclient :variables restclient-use-org t)
restructuredtext selectric octave purescript speed-reading systemd imenu-list
(java :variables java-backend 'meghanada)
groovy
(go :variables go-use-gometalinter t gofmt-command "goimports" go-tab-width 4 go-use-gocheck-for-testing t go-use-test-args "-race -timeout 10s" godoc-at-point-function 'godoc-gogetdoc)
coq django
(elm :variables elm-sort-imports-on-save t elm-format-on-save t)
idris
(haskell :variables haskell-enable-hindent-style "fundamental" haskell-completion-backend 'dante haskell-enable-hindent t)
pandoc sphinx parinfer asciidoc ansible puppet rebox rust xkcd typography vimscript
(terraform :variables terraform-auto-format-on-save t)
(ruby :variables ruby-enable-enh-ruby-mode t ruby-version-manager 'rvm)
ruby-on-rails asm
(sql :variables sql-capitalize-keywords t)
perl6 autohotkey
(elixir :variables flycheck-elixir-credo-strict t)
faust vagrant erlang
(dash :variables helm-dash-docset-newpath "~/.local/share/Zeal/Zeal/docsets")
games php nginx racket
(colors :variables colors-colorize-identifiers 'all)
d
(typescript :variables typescript-fmt-tool 'typescript-formatter typescript-fmt-on-save t))

System configuration features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES

syl20bnr commented 6 years ago

Promise, will fix it soon :D

sdwolfz commented 6 years ago

When running tests locally (in a VM since the tests mess up your ~/.emacs.d and ~/.spacemacs) the configuration-layer--used-layers vairables contains (spacemacs-bootstrap spacemacs-defaults spacemacs-base emacs-lisp git). It looks to me like the change should be:

diff --git a/tests/core/core-configuration-layer-ftest.el b/tests/core/core-configuration-layer-ftest.el
index 0ddcaa98..5c1b255a 100644
--- a/tests/core/core-configuration-layer-ftest.el
+++ b/tests/core/core-configuration-layer-ftest.el
@@ -33,7 +33,7 @@
         (configuration-layer--indexed-layers (make-hash-table :size 1024)))
     (configuration-layer/discover-layers 'refresh-index)
     (configuration-layer//declare-used-layers dotspacemacs-configuration-layers)
-    (should (eq 'spacemacs-base (second configuration-layer--used-layers)))))
+    (should (eq 'spacemacs-base (third configuration-layer--used-layers)))))

 ;; ---------------------------------------------------------------------------
 ;; Lazy installation of layers

sdwolfz commented 6 years ago

I've pushed 0d9b3490912f83f75462d14eb8abb320fb901661 that fixes the failures, tested it on an old PR of mine and it passes now.

The commit itself fails on deploy though... looks like a formatting issue in the python layer, I'll fix that next.

sdwolfz commented 6 years ago

And we have green!

Looks like all failing PRs opened in the last month need to be rebased.

syl20bnr / spacemacs