syl20bnr / spacemacs

A community-driven Emacs distribution - The best editor is neither Emacs nor Vim, it's Emacs *and* Vim!
http://spacemacs.org
GNU General Public License v3.0
23.67k stars 4.89k forks source link

frames-only-mode and compile #10694

Closed weidtn closed 5 months ago

weidtn commented 6 years ago

Not sure if this is the right place to ask:

Im pretty new to spacemacs. I use i3wm. I found the frames-only-mode and this is exactly what i need. magit opens its status in a new frame, just like I want it to. My problem is: When running my python scripts , c c the shell does not open a new frame. It's still in the same frame, under my code buffer.

io12 commented 4 years ago

I can reproduce this.

robertfw commented 4 years ago

May be related to https://github.com/davidshepherd7/frames-only-mode/issues/28

davidshepherd7 commented 3 years ago

Hi, maintainer of frames-only-mode here, do you know what , c c runs in vanilla emacs terms? I don't use spacemacs but run-python in plain emacs opens in a new frame and that sounds like the vanilla equivalent.

io12 commented 3 years ago

, c c runs spacemacs/python-execute-file, which internally calls compile with the shell command to run the file.

davidshepherd7 commented 3 years ago

Hmm, compile definitely works with vanilla emacs so it's probably a configuration issue. I'll have a look at the spacemacs when I get a chance.

Le sam. 21 nov. 2020 à 19:41, Ben Levy notifications@github.com a écrit :

, c c runs spacemacs/python-execute-file, which internally calls compile with the shell command to run the file.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/syl20bnr/spacemacs/issues/10694#issuecomment-731626766, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGCJVASJNCDESDLSNEZSHTSRAJWRANCNFSM4FATIRWQ .

davidshepherd7 commented 3 years ago

When I copy the definition of spacemacs/python-execute-file into my config and run it, it works as expected (opens a new frame for the compilation). I had a quick look around spacemacs to see if it is modifying any of the obvious settings but I can't find anything.

Some more questions which might help:

io12 commented 3 years ago

I just tried (for the first time since my initial comment), and I can't reproduce the bug anymore. Something must've fixed it since then.

@davidshepherd7 Thanks for frames-only-mode and trying to look into the issue.

@weidtn This issue seems fixed now so you can probably close it.

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!