Spaceline deferred loading broke things?

robbyoconnor commented 6 years ago

Description :octocat:

Spaceline theme doesn't work with resumed layouts in broke in 4bb1d6ab391c89e772de526e5d4b45d013dc4a74...

Reproduction guide :beetle:

Start Emacs
Have a few layouts open
SPC q r
go to the first layout

Observed behaviour: :eyes: :broken_heart: It shows in the Report-Issue buffer fine... but is wonky elsewhere

Expected behaviour: :heart: :smile: should look the same all over...

System Info :computer:

OS: gnu/linux
Emacs: 27.0.50
Spacemacs: 0.300.0
Spacemacs branch: develop (rev. 65018ea)
Graphic display: t
Distribution: spacemacs
Editing style: vim
Completion: ivy

Layers:

(coffeescript json bibtex nginx twitter graphviz
          (ivy :variables ivy-enable-advanced-buffer-information t)
          asciidoc speed-reading swift plantuml
          (auto-completion :variables auto-completion-return-key-behavior 'complete auto-completion-tab-key-behavior 'cycle auto-completion-complete-with-key-sequence nil auto-completion-enable-help-tooltip t auto-completion-enable-sort-by-usage t auto-completion-show-snippets-in-popup t auto-completion-private-snippets-directory "~/.spacemacs.d/snippets")
          better-defaults emacs-lisp
          (git :variables git-magit-status-fullscreen t)
          github gnus version-control
          (markdown :variables markdown-live-preview-engine 'vmd)
          syntax-checking
          (latex :variables latex-enable-auto-fill t)
          (colors :variables colors-colorize-identifiers 'all colors-enable-nyan-cat-progress-bar t)
          docker
          (ansible :variables ansible-auto-encrypt-decrypt t)
          puppet evil-commentary
          (evil-snipe :variables evil-snipe-enable-alternate-f-and-t-behaviors t)
          fasd finance floobits xkcd autohotkey csv
          (c-c++ :variables c-c++-enable-clang-support t)
          (clojure :variables clojure-enable-fancify-symbols t)
          major-modes
          (go :variables gofmt-command "goimports" go-use-gometalinter t go-use-gocheck-for-testing t go-use-test-args "-race -timeout 10s" godoc-at-point-function 'godoc-gogetdoc go-tab-width 2)
          (haskell :variables haskell-enable-ghci-ng-support t haskell-enable-shm-support t haskell-enable-hindent-style "andrew-gibiansky")
          html java
          (javascript :variables javascript-disable-tern-port-files t javascript-backend 'lsp)
          (python :variables python-backend 'lsp python-enable-yapf-format-on-save t python-fill-column 80 python-auto-set-local-pyenv-version 'on-visit python-auto-set-local-pyvenv-virtualenv 'on-visit python-sort-imports-on-save t python-test-runner
                  '(nose pytest))
          lsp racket
          (ruby :variables ruby-version-manager `rvm)
          ruby-on-rails
          (rust :variables rust-enable-rustfmt-on-save t)
          (scala :variables scala-indent:use-javadoc-style t scala-enable-eldoc t scala-auto-insert-asterisk-in-comments t scala-use-unicode-arrows t scala-auto-start-ensime t)
          shell-scripts
          (restclient :variables restclient-use-org t)
          themes-megapack tmux vim-empty-lines spotify vagrant
          (ibuffer :variables ibuffer-group-buffers-by 'projects)
          semantic deft
          (shell :variables shell-default-shell 'ansi-term shell-default-position 'bottom shell-default-height 30 shell-default-term-shell "/bin/zsh")
          erc chrome d emoji gtags prodigy evernote
          (org :variables org-enable-github-support t org-enable-reveal-js-support t org-enable-org-journal-support t org-enable-hugo-support t org-projectile-file "TODOs.org" org-want-todo-bindings t org-enable-bootstrap-support t)
          search-engine yaml sql nim ipython-notebook lua scheme purescript sml common-lisp ranger wakatime dash spell-checking jabber cscope vinegar rcirc games react php vimscript geolocation idris
          (elm :variables elm-reactor-port "3000" elm-reactor-address "0.0.0.0")
          elixir
          (typography :variables typography-enable-typographic-editing nil)
          pdf imenu-list slack systemd command-log
          (terraform :variables terraform-auto-format-on-save t)
          pass parinfer groovy kotlin unicode-fonts epub
          (treemacs :variables treemacs-use-follow-mode t treemacs-use-filewatch-mode t treemacs-use-collapsed-directories 3))

System configuration features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES THREADS XWIDGETS LIBSYSTEMD LCMS2

robbyoconnor commented 6 years ago

Yup, I was right...it didn't work well for this...

robbyoconnor commented 6 years ago

Appears that 86b4e6f...65018ea have had some adverse side effects.

Compro-Prasad commented 6 years ago

I think it should be something specific in your config that might causing it or the way you are using Emacs. I couldn't reproduce this issue with my config. I had two layouts open including the default one. Is that a problem?

rynffoll commented 6 years ago

I have the same problem. I reverted 4bb1d6ab3 commit temporarily.

syl20bnr commented 6 years ago

I pushed a fix in develop branch, please verify :-)

rynffoll commented 6 years ago

It didn't help in my case. I reproduced this bug by following steps:

Start spacemacs without restoring layouts
SPC b s

Also in *spacemacs* buffer I can see that my settings for spaceline from my private layout weren't applied.

Compro-Prasad commented 6 years ago

I got that too ^^. I believe it applies only to the home screen and not to all startup buffers.

rynffoll commented 6 years ago

Nope, it applies to other buffers too.

westlywright commented 6 years ago

I was having an issue with the zerodark-theme this morning and its mode line. I rolled back to c12b72 and do not see the issue. @syl20bnr i pulled the latest develop but still saw the issue.

Compro-Prasad commented 6 years ago

@rynffoll Like?

rynffoll commented 6 years ago

@Compro-Prasad I mean that my spaceline settings don't apply.

robbyoconnor commented 6 years ago

The layouts issue is fixed but I think these lazy loading introduced odd edge cases that need more testing.

robbyoconnor commented 6 years ago

I'm going to continue working from 86b4e6f76b062cbf921a617cc0eac5d73cb376a4

syl20bnr commented 6 years ago

I mean that my spaceline settings don't apply.

Found the issue, opened a PR upstream: https://github.com/TheBB/spaceline/pull/198 Hopefully it will be accepted.

BinaryKhaos commented 6 years ago

Basically all buffers that are created before spaceline is loaded and configured, will have a messed up powerline. Right now, only most of (not all) the startup buffers are explicitly set to the new modeline config after spaceline is ready but that's about it ("*Messages*", "*spacemacs*", "*Compile-Log*", but not "*scratch*" or any file buffer that was opened due to cmdline parameters):

https://github.com/syl20bnr/spacemacs/blob/8754b24509aaf13a6d08be3314280d5f4b5d702d/layers/%2Bspacemacs/spacemacs-modeline/packages.el#L141-L143

One solution would be to extend that to all buffers or simply don't idle load spaceline.

robbyoconnor commented 6 years ago

Most of this lazy loading are micro-optimizations that don't add much value but are causing a whole lot of regressions.

On 06/13/2018 09:56 AM, Matthias Dahl wrote:

Basically all buffers that are created /before/ spaceline is loaded and configured, will have a messed up powerline. Right now, only most of (not all) the startup buffers are explicitly set to the new modeline config after spaceline is ready but that's about it ("Messages", "spacemacs", "Compile-Log", but not "scratch" or any file buffer that was opened due to cmdline parameters):

https://github.com/syl20bnr/spacemacs/blob/8754b24509aaf13a6d08be3314280d5f4b5d702d/layers/%2Bspacemacs/spacemacs-modeline/packages.el#L141-L143

One solution would be to extend that to /all/ buffers or simply don't idle load spaceline.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/syl20bnr/spacemacs/issues/10849#issuecomment-396946351, or mute the thread https://github.com/notifications/unsubscribe-auth/AABaMMMKgRKiKoTjROm-sFhK_Hm-MDZgks5t8RoNgaJpZM4UicNe.

syl20bnr commented 6 years ago

Basically all buffers that are created before spaceline is loaded and configured, will have a messed up powerline.

Should be fixed in last develop.

BinaryKhaos commented 6 years ago

Should be fixed in last develop.

I can confirm it is fixed. Thanks (also for all the hard work and time you are investing into this project -- it is very much appreciated!).

syl20bnr commented 6 years ago

I pushed a new way to load the spaceline fast enough at startup without lazy-loading it in commit https://github.com/syl20bnr/spacemacs/commit/d7f5b5889

Should close this issue.

robbyoconnor commented 6 years ago

Should I close this?

BinaryKhaos commented 6 years ago

Sorry for not reporting back earlier but life got in the way (tm). From my side: Everything is back to normal wrt to spaceline/powerline, so if no one else has a problem, this can be closed.

syl20bnr / spacemacs