Closed smile13241324 closed 6 years ago
I'll take a look and see if I can figure it out.
Pushed 25827266a71be946d760b9d015ffff37563162f7 to disable the broken assertions but I don't know how to fix it properly, waiting for @syl20bnr to continue his work in that area.
It appears to me that some tests still fail consistently, i.e. the elisp tests / test (windows-latest, 26.3, core) (pull_request)
fails in the latest eight pull requests (starting from #13907).
Now I wonder if these PR's are still candidates/evaluated for merging (???). I have created #13927, and I see no reason why it should have broken anything.
@dalanicolai I don't think that your PR is causing these problems in CI and we are seeing the two mentioned PRs as candidates for merging. However #13907 is a draft release, therefore I have not checked it. I have read through #13927 already though I am not yet totally clear about what behaviour you have changed.
I don't know why the mentioned test fails, but I think @JAremko knows about these already.
Yeah we added more tests and found more bugs... I'm thinking about disabling some tests in PR testing and such, for now. But it kinda stinks. :thinking: windows-latest, 26.3, core
seems to be busted in spacelpa department and @syl20bnr planned to work on it.
Thanks for the replies!
@smile13241324 I will elaborate on the (small but very useful) changes in #13927 in the conversation of the PR itself.
Description :octocat:
I have changed some details on the "org" mode documentation and noticed that some tests do fail consistently for all recent PRs.
Namely these are: FAILED test-configure-packages-2--excluded-package-is-not-configured FAILED test-configure-packages-2--lazy-install-package-is-not-configured FAILED test-configure-packages-2--local-package-w/-bad-string-location-gives-warning FAILED test-configure-packages-2--local-package-w/-dotfile-owner-update-load-path FAILED test-configure-packages-2--local-package-w/-layer-owner-update-load-path FAILED test-configure-packages-2--local-package-w/-string-location-update-load-path FAILED test-configure-packages-2--local-package-w/o-owner-doesnt-update-load-path FAILED test-configure-packages-2--package-owned-by-dotfile-is-not-configured FAILED test-configure-packages-2--package-w/-layer-owner-is-configured FAILED test-configure-packages-2--package-w/o-owner-is-not-configured FAILED test-configure-packages-2--protected-excluded-package-is-configured FAILED test-configure-packages-2--protected-package-is-configured FAILED test-configure-packages-2--site-package-is-configured FAILED test-configure-packages-2--toggle-nil-is-not-configured FAILED test-configure-packages-2--toggle-t-is-configured
Reproduction guide :beetle:
Observed behaviour: :eyes: :broken_heart: Tests fail on all recent branches
Expected behaviour: :heart: :smile: Tests only fail if there is an issue with the contribution
System Info :computer: