spacemacs/python-execute-file cannot handle filenames with spaces

[rileylev]

Description :octocat:

spacemacs/python-execute-file does not properly handle filenames with spaces.

Reproduction guide :beetle:

• Start Emacs
• Call M-x find-file "two words.py"
• Save the file (<SPC> f s)
• Call M-x spacemac/python-execute-file

Observed behaviour: :eyes: :broken_heart: The *compilation* buffer says

-*- mode: compilation; default-directory: "~/" -*-
Comint started at Fri Jul 27 19:16:22

python two words.py
python: can't open file 'two': [Errno 2] No such file or directory

Inferior Python exited abnormally with code 2 at Fri Jul 27 19:16:23

Expected behaviour: :heart: :smile: The program should execute and *ipython* should display the results of execution

System Info :computer:

• OS: gnu/linux
• Emacs: 26.1
• Spacemacs: 0.200.13
• Spacemacs branch: riley (rev. fe7ba6ed6)
• Graphic display: t
• Distribution: spacemacs
• Editing style: hybrid
• Completion: helm
• Layers:

  (haskell themes-megapack python csv html markdown helm better-defaults common-lisp emacs-lisp clojure scheme latex git org spell-checking)

• System configuration features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES THREADS LIBSYSTEMD LCMS2

Backtrace :paw_prints:

[rileylev]

We're not sanitizing strings before passing to python in shell:

In the function spacemacs/python-execute-file in .emacs.d/+layers/python/funcs.el in the development branch, the compile-command is defined by

(format "%s %s"
         (spacemacs/pyenv-executable-find python-shell-interpreter)
         (file-name-nondirectory buffer-file-name))

If buffer-file-name has spaces in it ("two words.py"), the format command returns "/usr/bin/python two words.py", which will of course run python on two.

[rileylev]

I believe calling shell-quote-argument on the filename before passing to the format command fixes the problem:

(format "python %s" (shell-quote-argument (convert-standard-filename "two words.py")))

returns "python two\\ words.py"

[smile13241324]

Just noticed that this has been fixed on develop @bmag