Packages controlled by a toggle should not be managed by the layer it is defined.

robbyoconnor commented 5 years ago

Description :octocat:

A package managed by a variable toggle should allow for the package to be installed via dotspacemacs-additional-packages. This is tangentially related to #11379, though ox-hugo is used -- it would likely apply to other packages as well.

:notebook: I made this on behalf of @goofansu -- I do have hugo support enabled.

Reproduction guide :beetle:

Start Emacs
add ox-hugo to the additional packages list in dotspacemacs-additional-packages.
do not specify the org-enable-hugo-support toggle in the org layer in your layers list.

Observed behaviour: :eyes: :broken_heart: Does not install ox-hugo

Expected behaviour: :heart: :smile: Should install ox-hugo

System Info :computer:

OS: gnu/linux
Emacs: 27.0.50
Spacemacs: 0.300.0
Spacemacs branch: develop (rev. 9865e7731)
Graphic display: t
Distribution: spacemacs
Editing style: vim
Completion: ivy

Layers:

(prettier sphinx web-beautify transmission xclipboard node selectric
      (templates :variables templates-private-directory "~/.spacemacs.d/templates")
      coffeescript json jsonnet julia epub bibtex nginx twitter graphviz
      (ivy :variables ivy-enable-advanced-buffer-information t)
      asciidoc elfeed speed-reading swift plantuml
      (auto-completion :variables auto-completion-return-key-behavior 'complete auto-completion-tab-key-behavior 'cycle auto-completion-complete-with-key-sequence nil auto-completion-enable-help-tooltip t auto-completion-enable-sort-by-usage t auto-completion-show-snippets-in-popup t auto-completion-private-snippets-directory "~/.spacemacs.d/snippets")
      better-defaults emacs-lisp
      (git :variables git-magit-status-fullscreen t)
      github gnus version-control
      (markdown :variables markdown-live-preview-engine 'vmd)
      syntax-checking
      (latex :variables latex-enable-auto-fill t)
      (colors :variables colors-colorize-identifiers 'all colors-enable-nyan-cat-progress-bar t)
      docker
      (ansible :variables ansible-auto-encrypt-decrypt t)
      puppet evil-commentary
      (evil-snipe :variables evil-snipe-enable-alternate-f-and-t-behaviors t)
      fasd finance floobits xkcd autohotkey csv
      (c-c++ :variables c-c++-enable-clang-support t)
      major-modes
      (go :variables go-backend 'lsp gofmt-command "goimports" go-format-before-save t go-use-gometalinter t go-use-gocheck-for-testing t go-use-test-args "-race -timeout 10s" godoc-at-point-function 'godoc-gogetdoc go-tab-width 2)
      (haskell :variables haskell-enable-ghci-ng-support t haskell-enable-shm-support t haskell-enable-hindent-style "andrew-gibiansky")
      html java
      (javascript :variables javascript-disable-tern-port-files t javascript-backend 'lsp)
      (python :variables python-backend 'lsp python-enable-yapf-format-on-save t python-fill-column 80 python-auto-set-local-pyenv-version 'on-visit python-auto-set-local-pyvenv-virtualenv 'on-visit python-sort-imports-on-save t python-test-runner
              '(nose pytest))
      lsp racket
      (ruby :variables ruby-version-manager `rvm)
      ruby-on-rails
      (rust :variables rust-enable-rustfmt-on-save t)
      (scala :variables scala-indent:use-javadoc-style t scala-enable-eldoc t scala-auto-insert-asterisk-in-comments t scala-use-unicode-arrows t scala-auto-start-ensime t)
      shell-scripts
      (restclient :variables restclient-use-org t)
      themes-megapack tmux vim-empty-lines spotify pandoc vagrant
      (ibuffer :variables ibuffer-group-buffers-by 'projects)
      semantic deft
      (shell :variables shell-default-shell 'ansi-term shell-default-position 'bottom shell-default-height 30 shell-default-term-shell "/bin/zsh")
      typescript erc chrome d emoji gtags prodigy evernote
      (org :variables org-enable-github-support t org-enable-reveal-js-support t org-enable-org-journal-support t org-enable-hugo-support t org-projectile-file "TODOs.org" org-want-todo-bindings t org-enable-bootstrap-support t)
      search-engine yaml sql nim lua scheme purescript sml common-lisp ranger wakatime dash spell-checking jabber cscope vinegar games react php vimscript geolocation idris
      (elm :variables elm-reactor-port "3000" elm-reactor-address "0.0.0.0")
      elixir
      (typography :variables typography-enable-typographic-editing nil)
      emberjs pdf imenu-list slack systemd command-log
      (terraform :variables terraform-auto-format-on-save t)
      pass parinfer groovy kotlin unicode-fonts epub
      (treemacs :variables treemacs-use-follow-mode t treemacs-use-filewatch-mode t treemacs-use-collapsed-directories 3))

System configuration features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS XWIDGETS LIBSYSTEMD LCMS2 GMP

Backtrace :paw_prints:

<<BACKTRACE IF RELEVANT>>

emdash-ie commented 4 years ago

I have run into this problem with org-trello and org-jira, and #11633 is someone having the same problem. Would it be possible to at least add an error message to guide people towards the docs? I assumed a bug had been introduced into spacemacs that was preventing dotspacemacs-additional-packages from doing anything – I reckon it'd have been much clearer if there'd been an error message.

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

syl20bnr / spacemacs