syl20bnr / spacemacs

A community-driven Emacs distribution - The best editor is neither Emacs nor Vim, it's Emacs *and* Vim!
http://spacemacs.org
GNU General Public License v3.0
23.64k stars 4.89k forks source link

Provide a layer equivalent to pretty-fonts #11639

Closed mdedetrich closed 4 months ago

mdedetrich commented 5 years ago

As can be seen by https://github.com/tonsky/FiraCode/wiki/Emacs-instructions providing font-ligatures to emacs is far more complicated than what it should be.

I think it makes sense to provide a layer analogous to https://github.com/ekaschalk/.spacemacs.d/blob/master/layers/display/local/pretty-fonts/pretty-fonts.el so that people can easily configure font-ligatures, what do you guys think?

syl20bnr commented 5 years ago

Indeed that would be nice :+1:

georgreen commented 5 years ago

@mdedetrich doom emacs do have a rather complete implementation, including mathematics notation symbols. I would have taken up the port but I'm new to this stuff.

mdedetrich commented 5 years ago

@georgreen The link you posted doesn't work, care to update it?

georgreen commented 5 years ago

@georgreen The link you posted doesn't work, care to update it? @mdedetrich

done

ezmiller commented 5 years ago

@georgreen I'm new to spacemacs/emacs (coming from vim). Is the link you posted above somethign that can be used to get FiraCode working with spacemacs?

howdoicomputer commented 5 years ago

@ezmiller It'll probably be easier to follow the wiki instructions for FiraCode to enable ligatures. It's mostly copy and pasting a bunch of lisp into your user-config.

As for this thread, I am in love with https://github.com/ekaschalk/.spacemacs.d/tree/master/layers/display

@ekaschalk your stuff is awesome

Aberrantfox commented 5 years ago

Is there any progress on this? I've been trying to get ligatures working and it just doesn't seem to want to play ball... I'm not of the opinion that adding a bunch of elisp should be required t oget this kind of thing working, in vs code it's just a checkbox... Maybe I am missing a package that makes this very easy?

carusog commented 5 years ago

I started to use Spacemacs very little weeks ago, and I found super difficult to set up font ligatures from Fira Code in it. Not knowing how to set up .spacemacs correctly, I ended up choosing emacs-mac that with a one line of settings, enables ligatures immediately. I strongly believe that this should be a default feature in modern Spacemacs. I, like most of us, use it, in fact, just for the "out of the box" features, and is a great entry point to Emacs wonderful features. Modern development use ligatures quite commonly lastly. It would be great to have this feature built-in to the distribution.

ekaschalk commented 5 years ago

Ligatures are coming to Emacs FYI. Harfbuzz is integrated on Emacs master and Eli says it is the final step to (true) ligature support.

https://old.reddit.com/r/emacs/comments/byddvm/emacsdevel_harfbuzz_is_now_available_on_master/

hyiltiz commented 4 years ago

My SPC h d s includes HarfBuz, but how do I use it/enable it? Using Fire Code or Hasklig didn't render => as expected after an emacs restart.

System Info :computer:

Kazark commented 3 years ago

This PR was merged: https://github.com/syl20bnr/spacemacs/pull/13921 I think that is at least partly relevant.

hyiltiz commented 3 years ago

To anyone interested, it seem unicode-fonts provides unicode-fonts-ligature-modes and unicode-fonts-enable-ligatures, which may be how the new support may be used.

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

hyiltiz commented 2 years ago

Is this really resolved? If so, we should just close it before the bot seals the issue.

lebensterben commented 2 years ago

@hyiltiz Last time I tried unicode-fonts layer does provide proper ligatures in GUI emacs. So this problem per se is solved. Nevertheless it breaks lsp-ui.

hyiltiz commented 2 years ago

unicode-fonts breaks lsp-ui? Maybe we need to file an issue there and close this one?

lebensterben commented 2 years ago

It's long known and reported.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!