syl20bnr / spacemacs

A community-driven Emacs distribution - The best editor is neither Emacs nor Vim, it's Emacs *and* Vim!
http://spacemacs.org
GNU General Public License v3.0
23.67k stars 4.89k forks source link

Powerline does not scale correctly after upgrading emacs to 27.1 #13843

Closed yzh119 closed 2 years ago

yzh119 commented 4 years ago

Description :octocat:

After I upgrade my emacs from 26.3 to 27.1, the height of powerline becomes twice the size it previously was:

image

and change the value of powerline-scale does not help.

Reproduction guide :beetle:

Observed behaviour: :eyes: :broken_heart: The height of powerline is larger than it previously was.

Expected behaviour: :heart: :smile: The powerline should look "thinner".

System Info :computer:

practicalli-johnny commented 4 years ago

Use SPC f e D to ensure that the .spacemacs file is up to date with the spacemacs.template file. dotspacemacs-default-font no longer includes the :powerline-scale1.

 dotspacemacs-default-font '("Ubuntu Mono" :size 24.0 :weight normal :width normal)

The dotspacemacs-mode-line-theme has a optional :separator-scale configuration, adjusting or removing this option should affect the size of the modeline

dotspacemacs-mode-line-theme '(spacemacs :separator wave :separator-scale 1.5)

Alternatively, suggest trying a different font family or theme. There may also be something missing from the Emacs build.

If using doom or all-the-icons themes, ensure the command SPC SPC all-the-icons-install-fonts is run to download the required files for these modeline themes.

I have not seen issues raised like this on the Spacemacs Gitter community https://gitter.im/syl20bnr/spacemacs

Unfortunately the SPC h I key binding in Spacemacs was not used to raise this issue, so there is no information available about the system you are using and therefore it will be much harder to diagnose.

yzh119 commented 4 years ago

Hi @jr0cket , I updated the issue description following your template. Yes I do think it's because of font, I'll try to figure out a workaround.

duianto commented 4 years ago

If someone else encounters the same issue, it would be helpful to know what you were using when the issue occurred:

andreyk0 commented 4 years ago

@duianto experienced the same issue on Arch / gnome / wayland / HiDpi screen @ 200%. My config is here.

I do have the fonts explicitly set in the config and was running with dotspacemacs-mode-line-theme '(vim-powerline) before the update.

dotspacemacs-default-font '("Source Code Pro Medium" :size 13.0 :weight normal :width normal)

If someone's looking for a way to re-create the issue -maybe this'll help.

After update tried to fiddle with a few more themes. Emacs default one didn't have this issue. Tried doom and it worked with an extra hack that I pasted from some search result. Ugly but works for now, sorry, I don't know elisp, can't fix this properly.

yzh119 commented 4 years ago

@duianto, I'm using Arch / gnome / xorg / HiDpi screen @ 200%. The theme used is tango-dark, and trying other themes doesn't help (like @andreyk0 ). font configuration:

   dotspacemacs-default-font '("Source Code Pro"
                               :size 28
                               :weight normal
                               :width normal
                               :powerline-scale 1)
duianto commented 4 years ago

Maybe there's some useful info here: https://www.reddit.com/r/emacs/comments/51wm7d/emacs_on_hidpi_displays/

ghost commented 4 years ago

Hi, I have the same problem since the emacs 27.1 upgrade. I run Arch / i3-gaps / xserver / Xft.dpi: 192 Here is what it looks like: https://folio.ink/SevRmI Here is my config file: https://github.com/philippera/arch-dotfiles/blob/master/homedir/.spacemacs For me changing themes does not change the problem and the powerline-scale option does nothing. dotspacemacs-default-font '("Source Code Pro" :size 13.0 :weight normal :width normal)

ghost commented 4 years ago

dotspacemacs-mode-line-theme '(spacemacs :separator wave :separator-scale 0.5)

:separator-scale at 0.5 solves the problem for me

yzh119 commented 4 years ago

@philippera 's solution works for me as well :)

yang-ling commented 4 years ago

@duianto

Is it a HiDPI display and is it using any OS level scaling

→ I can confirm this issue only happens when you use HiDPI display and set scaling. I have installed spacemacs both on my home MacBookPro and my work PC. Spaceline looks well on my work PC, but it looks much more larger on my home MBP.

I solved it by changing dotspacemacs-mode-line-theme setting.

You can:

@jr0cket Your comments are very helpful. Thanks!

laynor commented 3 years ago

I just fixed a very similar issue to this one in my config. The issue was related, at least in my case, to the font fallback. Try opening spaceline-segments.el and check the function spaceline--unicode-number. In my case the lines where the unicode chars appear had lots of interline spacing. It was due to emacs selecting Noto Sans to display the symbols, which appears to have a very different height w.r.t. my default font, at least when displaying those symbols. You can verify what font is being used with M-x describe-char. I solved my issue adding this to my config:

  (set-fontset-font "fontset-default" 'symbol (font-spec :size 12 :name "Symbols Nerd Font Bold"))

in my dotspacemacs/user-config function.

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

lebensterben commented 2 years ago

For future references, try setting :separator-scale 0.5 in dotspacemacs-mode-line-theme on high DPI.