Unable to select directory when using spacemacs/helm-files-smart-do-search with only grep installed.

dalanicolai commented 3 years ago

Description :octocat:

Unable to select directory when using spacemacs/helm-files-smart-do-search with only grep installed. Instead helm enters the directory (while when e.g. ripgrep is installed, then a directory can be selected with enter)

Reproduction guide :beetle:

Start Spacemacs (using helm) on a system without any alternative (to grep) search tools installed
Try to select a directory by selecting it in helm en pressing RET

Observed behaviour: :eyes: :broken_heart: Helm enters the directory

Expected behaviour: :heart: :smile: Helm starts the grep search in the selected directory

System Info :computer:

OS: gnu/linux
Emacs: 27.2
Spacemacs: 0.300.0
Spacemacs branch: develop (rev. 80e2fd427)
Graphic display: t
Distribution: spacemacs
Editing style: vim
Completion: helm

Layers:

(auto-completion emacs-lisp git helm lsp markdown multiple-cursors org
             (shell :variables shell-default-height 30 shell-default-position 'bottom)
             spell-checking syntax-checking treemacs djvu)

System configuration features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS XWIDGETS LIBSYSTEMD JSON PDUMPER GMP

Backtrace :paw_prints:

<<BACKTRACE IF RELEVANT>>

lebensterben commented 3 years ago

there's no feature parity currently, that's solved by my unfinished PR.

smile13241324 commented 3 years ago

I need to lookup how registering handlers for helm works to fix this. I wanted to do that anyway to understand why we cannot resume some buffers i.e. swap buffer. But this may take some time.

dalanicolai commented 3 years ago

Well, I am usually using Ivy anyway. Also, I guess most users will have some faster search tool installed, so the priority is really low. But I was installing a fresh Spacemacs in a fresh OS installation, and then I noticed this, so I just reported it.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

syl20bnr / spacemacs