syl20bnr / spacemacs

A community-driven Emacs distribution - The best editor is neither Emacs nor Vim, it's Emacs *and* Vim!
http://spacemacs.org
GNU General Public License v3.0
23.64k stars 4.89k forks source link

The width of left margin to show line numbers is not consistent #14837

Closed aruku7230 closed 5 months ago

aruku7230 commented 3 years ago

Description :octocat:

The width of left margin to show line numbers is not consistent

Reproduction guide :beetle:

Observed behaviour: :eyes: :broken_heart:

line 1000 is the current line. | represent the boundary of left margin and the buffer content.

image

Expected behaviour: :heart: :smile:

the right of line numbers is aligned.

System Info :computer:

aruku7230 commented 3 years ago

What mode does Spacemacs use to show line numbers, linum-mode or display-line-numbers-mode?

lebensterben commented 3 years ago

should be linum

lebensterben commented 3 years ago

well. the new behavior is to use display-line-number-mode unless you haven't updated dotspacemacs then it fallsback to linum package

https://github.com/syl20bnr/spacemacs/blob/c1c18b7eedc9bc6ee07618f064e8eb8d9ef58337/layers/%2Bspacemacs/spacemacs-defaults/funcs.el#L1725

duianto commented 3 years ago

Could it be a font issue?

It looks correct for me, with the Source Code Pro font: harfbuzz:-outline-Source Code Pro-normal-normal-normal-mono-13-*-*-*-c-*-iso8859-1 (#x1C) source: The current font can be seen by pressing SPC h d c (calls describe-char) That line appears at the end of the first paragraph in the Help buffer.

emacs_9XNUJpQKdi

System Info
#### System Info :computer:
- OS: windows-nt
- Emacs: 27.2
- Spacemacs: 0.300.0
- Spacemacs branch: develop (rev. 120ce6959)
- Graphic display: t
- Distribution: spacemacs
- Editing style: vim
- Completion: helm
- Layers:
```elisp
(auto-completion autohotkey emacs-lisp git helm html javascript multiple-cursors org spell-checking syntax-checking version-control treemacs)
```
- System configuration features: XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY W32NOTIFY ACL GNUTLS LIBXML2 HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS MODULES THREADS JSON PDUMPER LCMS2 GMP
aruku7230 commented 3 years ago

@duianto , I updated the reproduction guide by adding headlines on org file and then fold the headline reproduced it.

duianto commented 3 years ago

Confirmed, I'm also able to reproduce it now.

emacs_4OMLYNpQu5

It isn't limited to Spacemacs, it also happens with: runemacs -Q (it starts Emacs without any configurations)

emacs_x6KzOUvkTi

github-actions[bot] commented 8 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!