search

syl20bnr / spacemacs

A community-driven Emacs distribution - The best editor is neither Emacs nor Vim, it's Emacs *and* Vim!
http://spacemacs.org
GNU General Public License v3.0
23.69k stars 4.9k forks source link

Addition to git layer: blamer #15122

Closed phenix-factory closed 5 months ago

phenix-factory commented 3 years ago

Hello,

I just found this package on HN and I think it would be nice to have it in the git layer.

https://github.com/Artawower/blamer.el

BenedictHW commented 3 years ago

Thanks for linking the HN discussion, good stuff. The comments mention this functionality is already available in magit-blame, though not very well advertised.

  1. M-x RET magit-blame RET m (or b) inside a source code buffer to activate the magit blame minor mode and then move the pointer around. There should be blame context in the minibuffer.
  2. M-x RET magit-blame-cycle-style when in magit-blame mode. This is awesome. Might just replace SPC g f l (magit-log-buffer-file) and C-x v g (vc-annotate) for me.

https://magit.vc/manual/magit/Blaming.html

phenix-factory commented 3 years ago

Thanks for linking the HN discussion, good stuff.

Irony I guess. You right anyway: Thanks for linking the HN discussion, good stuff.

The comments mention this functionality is already available in magit-blame, though not very well advertised.

This is not really the same functionality. I know about magit-blame. Blamer does it differently since the blame is always on and on every line you move your cursor on.

smile13241324 commented 2 years ago

We can add blamer to the git layer and have users make a choice between blamer and magit blame via a config var. In both cases we should have clear bindings for this feature.

github-actions[bot] commented 8 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!