[unicode-fonts] mapping unicode blocks on every Spacemacs start (Emacs 29 - pcache issue)

practicalli-johnny commented 2 years ago

Description :octocat:

Unicode font mapping each time Spacemacs is started, rather than being cached

Spacemacs can take up to a minute to start due to a process that maps unicode blocks on fonts and the results of this process are not being cached.

Progress of mapping appears in the mini-buffer on Spacemacs startup.

In *messages* buffer on startup the following entries are added

Unicode Fonts - Mapping Unicode Blocks in fontset-default ... done
Unicode Fonts - Mapping Overrides in fontset-default ... done
Unicode Fonts - Mapping Unicode Blocks in fontset-startup ... done
Unicode Fonts - Mapping Overrides in fontset-startup ... done
Unicode Fonts - Mapping Unicode Blocks in fontset-standard ... done
Unicode Fonts - Mapping Overrides in fontset-standard ... done

Reproduction guide :beetle:

Edit the Spacemacs configuration file and add the unicode-fonts layer with variables to enable ligatures

     (unicode-fonts :variables
                    unicode-fonts-enable-ligatures t
                    unicode-fonts-ligature-modes '(prog-mode))

Set the Spacemacs font to FiraCode (or any font that supports ligatures)

   dotspacemacs-default-font '("Fira Code"
                               :size 12.0
                               :weight normal
                               :width normal)

Install FiraCode font, or any font with ligature support, on the operating system.
Restart Emacs

Observed behaviour: :eyes: :broken_heart:

Unicode fonts are mapped each time

Expected behaviour: :heart: :smile:

Unicode font mapping should be saved in the Spacemacs cache, so only runs once (unless font / configuration is changed)

System Info :computer:

OS: gnu/linux
Emacs: 29.0.50
Spacemacs: 0.999.0
Spacemacs branch: develop (rev. 9b6083b32)
Graphic display: t
Distribution: spacemacs
Editing style: vim
Completion: helm

Layers:

(asciidoc
(auto-completion :variables auto-completion-enable-help-tooltip t auto-completion-enable-snippets-in-popup t auto-completion-enable-sort-by-usage t)
(clojure :variables clojure-enable-kaocha-runner t cider-repl-display-help-banner nil cider-print-fn 'puget clojure-indent-style 'align-arguments clojure-align-forms-automatically t clojure-toplevel-inside-comment-form t cider-result-overlay-position 'at-point cider-overlays-use-font-lock t cider-repl-buffer-size-limit 100)
colors command-log csv emacs-lisp emoji
(git :variables git-magit-status-fullscreen t magit-diff-refine-hunk t git-enable-magit-todos-plugin t)
graphviz
(helm :variables helm-follow-mode-persistent t)
html javascript json
(lsp :variables lsp-enable-on-type-formatting t lsp-enable-indentation t lsp-enable-snippet t lsp-enable-symbol-highlighting t lsp-modeline-diagnostics-enable t lsp-ui-doc-show-with-cursor nil lsp-ui-doc-include-signature t lsp-ui-doc-alignment 'window lsp-ui-sideline-enable nil lsp-ui-sideline-show-code-actions nil lsp-lens-enable t treemacs-space-between-root-nodes nil lsp-file-watch-threshold 10000 lsp-log-io nil)
(markdown :variables markdown-live-preview-engine 'vmd)
multiple-cursors
(org :variables org-enable-github-support t org-enable-bootstrap-support t org-enable-reveal-js-support t org-want-todo-bindings t org-enable-org-journal-support t org-journal-dir "~/projects/journal/" org-journal-file-format "%Y-%m-%d" org-journal-date-prefix "#+TITLE: " org-journal-date-format "%A, %B %d %Y" org-journal-time-prefix "* " org-journal-time-format "" org-journal-carryover-items "TODO=\"TODO\"|TODO=\"DOING\"|TODO=\"BLOCKED\"|TODO=\"REVIEW\"")
(ranger :variables ranger-show-preview t ranger-show-hidden t ranger-cleanup-eagerly t ranger-cleanup-on-disable t ranger-ignored-extensions
     '("mkv" "flv" "iso" "mp4"))
(shell :variables shell-default-shell 'eshell shell-default-height 30 shell-default-position 'bottom)
(spacemacs-layouts :variables spacemacs-layouts-restrict-spc-tab t persp-autokill-buffer-on-remove 'kill-weak)
(spacemacs-modeline :variables doom-modeline-height 12 doom-modeline-major-mode-color-icon t doom-modeline-buffer-file-name-style 'relative-to-project doom-modeline-display-default-persp-name t doom-modeline-minor-modes nil doom-modeline-modal-icon nil)
spell-checking
(syntax-checking :variables syntax-checking-use-original-bitmaps t)
(treemacs :variables treemacs-indentation 1 treemacs-use-filewatch-mode t treemacs-use-follow-mode t)
theming
(unicode-fonts :variables unicode-fonts-enable-ligatures t unicode-fonts-ligature-modes
            '(prog-mode))
(version-control :variables version-control-diff-tool 'diff-hl version-control-global-margin t)
yaml)

System configuration features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM XWIDGETS GTK3 ZLIB

Backtrace :paw_prints:

<<BACKTRACE IF RELEVANT>>

practicalli-johnny commented 2 years ago

This issue did not occur on Emacs 27, which I was using up until 21st April. There is a ~/.emacs.d/.cache/pcache/unicode-fonts file from that time with the following header

(pcache-repository "unicode-fonts"
  :file "unicode-fonts"
  :object-name "unicode-fonts"
  :version "27.1/0.5"

So it would seem that this issue affects Emacs versions after 27.1 at some point.

I am using a recent build of Emacs 29 (from Ubuntu Emacs PPA) and no new files are being created in ~/.emacs.d/.cache/pcache/ or in ~/.emacs.d/var/pcache/

Related issues

practicalli-johnny commented 2 years ago

Using Emacs 28.1 on Ubuntu the issue no longer occurs. A new version of the ~/.emacs.d/.cache/unicode-fonts file is created for Emacs version 28.1

(pcache-repository "unicode-fonts"
  :file "unicode-fonts"
  :object-name "unicode-fonts"
  :version "28.1/0.5"

Emacs 28 does not seem to be packaged for Ubuntu, although the steps to build from the Emacs source code are relatively straight forward: https://practical.li/blog/posts/build-emacs-28-on-ubuntu/

LemonBreezes commented 2 years ago

I don't know what's causing this issue but it's occurring in the (cl-call-next-method) call within make-instance. I don't really know much about eieio though. EDIT: I've commented on https://github.com/sigma/pcache/issues/16 as well.

LemonBreezes commented 2 years ago

I have just submitted a pull request fixing this issue: https://github.com/sigma/pcache/pull/17.

syl20bnr / spacemacs