Enabling `nav-flash` layer causes persistent `Can’t load buffer Makefile: Wrong type argument: overlayp, nil` errors.

pataquets commented 2 years ago

Description :octocat:

Enabling nav-flash layer causes persistent Can’t load buffer Makefile: Wrong type argument: overlayp, nil errors.

Reproduction guide :beetle:

Start Emacs

Enable nav-flash layer:

 (nav-flash :variables
            nav-flash-use-pulse t)

Observed behaviour: :eyes: :broken_heart: On each file open, the following error appears:

Can’t load buffer Makefile: Wrong type argument: overlayp, nil

Also, jumping pages in buffers or directly invoking layer's nav-flash function causes the error to appear.

Expected behaviour: :heart: :smile: No error.

System Info :computer:

OS: Ubuntu Bionic
Emacs: 28.1 (from kelleyk's PPA)
Spacemacs: 0.999.0
Spacemacs branch: develop (rev. c9db02842)
Graphic display: happens both on GUI and TTY
Running in daemon: t
Distribution: spacemacs
Editing style: vim
Completion: helm

Layers:

(asciidoc auto-completion better-defaults
      (colors :variables colors-enable-nyan-cat-progress-bar nil)
      command-log copy-as-format csv
      (dash :variables dash-docs-browser-func 'eww dash-docs-docset-newpath "~/.local/share/Zeal/Zeal/docsets/")
      (docker :variables dockerfile-keymap-show-docker-bindings t docker-container-default-sort-key
              '("Status" . t)
              docker-image-default-sort-key
              '("Created" . t)
              docker-run-default-args
              '("-i" "-t" "--rm"))
      (elfeed :variables elfeed-use-curl t)
      emacs-lisp emoji
      (git :variables git-enable-magit-todos-plugin t)
      go gtags
      (helm :variables helm-use-fuzzy 'always helm-ff-history-max-length '1000 helm-follow-mode-persistent t helm-imenu-use-icon t helm-mini-default-sources
            '(helm-source-buffers-list helm-source-recentf helm-source-bookmarks helm-source-buffer-not-found))
      (ibuffer :variables ibuffer-group-buffers-by 'projects)
      lua markdown
      (org :variables org-hide-emphasis-markers t org-hide-leading-stars t org-link-abbrev-alist
           '(("google" . "https://google.com/search?q=%s"))
           org-want-todo-bindings t)
      (pocket :variables pocket-reader-archive-on-open nil pocket-reader-open-url-default-function 'eww-browse-url)
      python ranger restclient
      (search-engine :variables search-engine-amazon-tld "es")
      (shell :variables shell-default-shell 'vterm vterm-always-compile-module t vterm-buffer-name-string "%s" vterm-kill-buffer-on-exit t vterm-max-scrollback 1000000)
      (shell-scripts :variables shell-scripts-format-on-save nil)
      speed-reading themes-megapack
      (wakatime :variables wakatime-cli-path "/usr/local/bin/wakatime")
      unicode-fonts vimscript
      (vinegar :variables vinegar-reuse-dired-buffer t vinegar-dired-hide-details nil)
      (eww :variables eww-history-limit 1000 eww-browse-url-new-window-is-tab t eww-search-prefix "https://google.com/?q=")
      (w3m :location
           (recipe :fetcher github :repo "venmos/w3m-layer")
           :variables w3m-home-page "about:blank" w3m-use-title-buffer-name t w3m-quick-start nil w3m-command-arguments
           '("-cookie" "-F")
           w3m-use-cookies t w3m-default-display-inline-images t w3m-default-toggle-inline-images t w3m-history-minimize-in-new-session t w3m-session-autosave t w3m-session-load-last-sessions t w3m-session-load-crashed-sessions t w3m-view-this-url-new-session-in-background t)
      yaml)

System configuration features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM XWIDGETS GTK3 ZLIB

thanhvg commented 2 years ago

Does it work if you remove nav-flash-use-pulse t. Also does your w3m work?

lebensterben commented 2 years ago

it turns out that if nav-flash-use-pulse is set to any non-nil value, spacemacs home buffer won't be loaded correctly. Therefore there must be some errors occurred during an invocation of nav-flash.

pataquets commented 2 years ago

Confirming, problem only exists if setting nav-flash-use-pulse to t. Setting it to nil avoids the error. My w3m package works OK, but I only use it occasionally.

lebensterben commented 2 years ago

I'm not able too figure out the cause of the bug. I will make a workaround that force nav-flash-use-pulse to nil while emitting a warning.

(If I set nav-flash-use-pulse to t after Spacemacs started it works though)

lebensterben commented 2 years ago

I find the fix from Doom Emacs and I will push them.

syl20bnr / spacemacs