syl20bnr / spacemacs

A community-driven Emacs distribution - The best editor is neither Emacs nor Vim, it's Emacs *and* Vim!
http://spacemacs.org
GNU General Public License v3.0
23.67k stars 4.89k forks source link

helm-M-x-execute-command: Wrong type argument: commandp, <command> \ \ #16007

Closed drewverlee closed 1 year ago

drewverlee commented 1 year ago

Description :octocat:

Pressing hot keys "SPC SPC" aka spacemacs/helm-M-x-fuzzy-matching, then selecting a emacs command (e.g cider-inspect-last-result) does nothing, when i expected it to issue the command. Instead, i just get this in my message buffer

helm-M-x-execute-command: Wrong type argument: commandp, cider-inspect-last-result\ \

Note, this happens for all commands, not just the cider one. E.g

helm-M-x-execute-command: Wrong type argument: commandp, spacemacs/toggle-debug-on-error\ \

And, if i just use the keyboard short cut for the command, it does work. I think the issue is the double backlashes at the end of the command.

Reproduction guide :beetle:

Observed behaviour: :eyes: :broken_heart: the command called with spacemacs/helm-M-x-fuzzy-matching doesn't happen.

Expected behaviour: :heart: :smile: the command called with spacemacs/helm-M-x-fuzzy-matching does happen.

System Info :computer:

Backtrace :paw_prints:

Debugger entered--Lisp error: (wrong-type-argument commandp cider-inspect-last-result\ \ )
  call-interactively(cider-inspect-last-result\ \  record nil)
  command-execute(cider-inspect-last-result\ \  record)
  helm-M-x-execute-command(cider-inspect-last-result\ \ )
  helm-execute-selection-action-1()
  helm-execute-selection-action()
  helm-internal((((name . "Emacs Commands history") (init #f(compiled-function () #<bytecode -0x430f5f468c703ba>)) (candidates . helm-candidates-in-buffer) (cleanup . helm-M-x--unwind-forms) (keymap keymap (keymap ...) keymap (29 . helm-M-x-toggle-short-doc) (21 . helm-M-x-universal-argument) keymap (127 . helm-mode-delete-char-backward-maybe) (27 keymap ...) (C-return . helm-cr-empty-string) keymap (C-iso-lefttab . helm-follow-action-backward) (26 . helm-select-action) (tab . helm-execute-persistent-action) (33554440 . describe-key) (33554443 . helm-follow-action-backward) (33554442 . helm-follow-action-forward) (17 . ace-jump-helm-line) (f12 . #f(comp
lebensterben commented 1 year ago

helm layer hasn't been changed for 7 months.

Does this issue start to appear recently?

drewverlee commented 1 year ago

@lebensterben yes. I have run into it 3 times in the last .. idk 5 days? I have to restart emacs each time.

lebensterben commented 1 year ago

I don't think this is caused by Spacemacs.

Have you updated all packages?

drewverlee commented 1 year ago

@lebensterben yes. I regularly update my packages all at once. So when this bug was occurring all the packages were relatively up to date (within days).

Why don't you think it's caused by spacemacs? Your early comment seems to imply it's not caused by helm either as it hasn't changed. I'm probably confused but if use the emacs fn pkg-info-package-version on helm, i get 20230501.1445, which implies to me, that helm changed 3 days ago.

I assume it's helm related because helm is featured predominantly in the stacktrace. Can you share with me what you gather from that stack trace? Any quick intuition would be helpful.

lebensterben commented 1 year ago

helm changed. but Spacemacs' completion layer hasn't changed for more than half year.

drewverlee commented 1 year ago

@lebensterben. given spacemacs hasn't changed on this front, your are right to assume atm it's not the issue. Should we close this? I'll re-open the issue with helm and see if anyone there has any ideas. Ty for your time :)

lebensterben commented 1 year ago

I am still confused why the extra "\"s are appended to correct command names. But I don't see the error myself.

drewverlee commented 1 year ago

@lebensterben me to, that seems to be the problem. Next time it happens, ill try to dig deeper. Maybe it never will!

smile13241324 commented 1 year ago

Hi :),

as there has been no activity on this issue since May I would like to close it. @drewverlee feel free to reopen it when the issue reappears.

mfg Maxi

dmg46664 commented 10 months ago

@drewverlee This has been happening to me. Please update if you have further insight? 🙏

drewverlee commented 10 months ago

@drewverlee This has been happening to me. Please update if you have further insight? 🙏

I'm not running into this any more but as so often with these things i can't recall why and when it stopped unfortunately.